chrome/common/extensions/PRESUBMIT.py - Issue 887033002: Cleanup: Presubmit API is built into depot_tools.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/PRESUBMIT.py

Issue 887033002: Cleanup: Presubmit API is built into depot_tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/web_dev_style/css_checker.py ('k') | chrome/common/extensions/docs/server2/PRESUBMIT.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Presubmit script for changes affecting extensions.	5 """Presubmit script for changes affecting extensions.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

8 for more details about the presubmit API built into gcl.	8 for more details about the presubmit API built into depot_tools.

9 """	9 """

10 import fnmatch	10 import fnmatch

11 import os	11 import os

12 import re	12 import re

13	13

14 EXTENSIONS_PATH = os.path.join('chrome', 'common', 'extensions')	14 EXTENSIONS_PATH = os.path.join('chrome', 'common', 'extensions')

15 DOCS_PATH = os.path.join(EXTENSIONS_PATH, 'docs')	15 DOCS_PATH = os.path.join(EXTENSIONS_PATH, 'docs')

16 SERVER2_PATH = os.path.join(DOCS_PATH, 'server2')	16 SERVER2_PATH = os.path.join(DOCS_PATH, 'server2')

17 API_PATH = os.path.join(EXTENSIONS_PATH, 'api')	17 API_PATH = os.path.join(EXTENSIONS_PATH, 'api')

18 TEMPLATES_PATH = os.path.join(DOCS_PATH, 'templates')	18 TEMPLATES_PATH = os.path.join(DOCS_PATH, 'templates')

(...skipping 142 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
161 return results	161 return results

162	162

163 def CheckChangeOnUpload(input_api, output_api):	163 def CheckChangeOnUpload(input_api, output_api):

164 results = []	164 results = []

165 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)	165 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)

166 results += _CheckChange(input_api, output_api)	166 results += _CheckChange(input_api, output_api)

167 return results	167 return results

168	168

169 def CheckChangeOnCommit(input_api, output_api):	169 def CheckChangeOnCommit(input_api, output_api):

170 return _CheckChange(input_api, output_api)	170 return _CheckChange(input_api, output_api)

OLD	NEW