build/ios/PRESUBMIT.py - Issue 887033002: Cleanup: Presubmit API is built into depot_tools.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/ios/PRESUBMIT.py

Issue 887033002: Cleanup: Presubmit API is built into depot_tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import os	5 import os

6	6

7 """Chromium presubmit script for src/tools/ios.	7 """Chromium presubmit script for src/tools/ios.

8	8

9 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts	9 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

10 for more details on the presubmit API built into gcl.	10 for more details on the presubmit API built into depot_tools.

11 """	11 """

12	12

13 WHITELIST_FILE = 'build/ios/grit_whitelist.txt'	13 WHITELIST_FILE = 'build/ios/grit_whitelist.txt'

14	14

15 def _CheckWhitelistSorted(input_api, output_api):	15 def _CheckWhitelistSorted(input_api, output_api):

16 for path in input_api.LocalPaths():	16 for path in input_api.LocalPaths():

17 if WHITELIST_FILE == path:	17 if WHITELIST_FILE == path:

18 lines = open(os.path.join('../..', WHITELIST_FILE)).readlines()	18 lines = open(os.path.join('../..', WHITELIST_FILE)).readlines()

19 i = 0	19 i = 0

20 while i < len(lines) - 1 and lines[i] <= lines[i + 1]:	20 while i < len(lines) - 1 and lines[i] <= lines[i + 1]:

(...skipping 12 matching lines...) Expand all Loading...
33	33

34 def CheckChangeOnUpload(input_api, output_api):	34 def CheckChangeOnUpload(input_api, output_api):

35 results = []	35 results = []

36 results.extend(_CommonChecks(input_api, output_api))	36 results.extend(_CommonChecks(input_api, output_api))

37 return results	37 return results

38	38

39 def CheckChangeOnCommit(input_api, output_api):	39 def CheckChangeOnCommit(input_api, output_api):

40 results = []	40 results = []

41 results.extend(_CommonChecks(input_api, output_api))	41 results.extend(_CommonChecks(input_api, output_api))

42 return results	42 return results

OLD	NEW

« no previous file with comments | « build/android/PRESUBMIT.py ('k') | chrome/PRESUBMIT.py » ('j') | no next file with comments »