Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: base/PRESUBMIT.py

Issue 887033002: Cleanup: Presubmit API is built into depot_tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/resources/PRESUBMIT.py ('k') | build/android/PRESUBMIT.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Chromium presubmit script for src/base. 5 """Chromium presubmit script for src/base.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details on the presubmit API built into gcl. 8 for more details on the presubmit API built into depot_tools.
9 """ 9 """
10 10
11 def _CheckNoInterfacesInBase(input_api, output_api): 11 def _CheckNoInterfacesInBase(input_api, output_api):
12 """Checks to make sure no files in libbase.a have |@interface|.""" 12 """Checks to make sure no files in libbase.a have |@interface|."""
13 pattern = input_api.re.compile(r'^\s*@interface', input_api.re.MULTILINE) 13 pattern = input_api.re.compile(r'^\s*@interface', input_api.re.MULTILINE)
14 files = [] 14 files = []
15 for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile): 15 for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile):
16 if (f.LocalPath().startswith('base/') and 16 if (f.LocalPath().startswith('base/') and
17 not "/ios/" in f.LocalPath() and 17 not "/ios/" in f.LocalPath() and
18 not "/test/" in f.LocalPath() and 18 not "/test/" in f.LocalPath() and
(...skipping 21 matching lines...) Expand all
40 def CheckChangeOnUpload(input_api, output_api): 40 def CheckChangeOnUpload(input_api, output_api):
41 results = [] 41 results = []
42 results.extend(_CommonChecks(input_api, output_api)) 42 results.extend(_CommonChecks(input_api, output_api))
43 return results 43 return results
44 44
45 45
46 def CheckChangeOnCommit(input_api, output_api): 46 def CheckChangeOnCommit(input_api, output_api):
47 results = [] 47 results = []
48 results.extend(_CommonChecks(input_api, output_api)) 48 results.extend(_CommonChecks(input_api, output_api))
49 return results 49 return results
OLDNEW
« no previous file with comments | « ash/resources/PRESUBMIT.py ('k') | build/android/PRESUBMIT.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698