Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 887023002: [DevTools] DevToolsUIBindings::CallClientFunction - reduce number of string copyings (Closed)

Created:
5 years, 10 months ago by vkuzkokov
Modified:
5 years, 10 months ago
Reviewers:
dgozman
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] DevToolsUIBindings::CallClientFunction - reduce number of string copyings BUG= Committed: https://crrev.com/4f0742210724c4295e7633f7d7e09033d73d8777 Cr-Commit-Position: refs/heads/master@{#313905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 chunk +7 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vkuzkokov
5 years, 10 months ago (2015-01-30 12:03:57 UTC) #2
dgozman
lgtm
5 years, 10 months ago (2015-01-30 12:30:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887023002/1
5 years, 10 months ago (2015-01-30 12:32:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 13:12:26 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 13:13:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f0742210724c4295e7633f7d7e09033d73d8777
Cr-Commit-Position: refs/heads/master@{#313905}

Powered by Google App Engine
This is Rietveld 408576698