Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 887013003: [x64] Assembler support for internal references and RIP relative addressing. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Assembler support for internal references and RIP relative addressing. R=dcarney@chromium.org BUG=v8:3872 LOG=n Committed: https://crrev.com/008f4732f78f71d8d37bc574b75d5bccff94025b Cr-Commit-Position: refs/heads/master@{#26486}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -27 lines) Patch
M src/x64/assembler-x64.h View 9 chunks +15 lines, -4 lines 0 comments Download
M src/x64/assembler-x64.cc View 6 chunks +82 lines, -19 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 2 chunks +7 lines, -2 lines 0 comments Download
M src/x64/disasm-x64.cc View 2 chunks +3 lines, -1 line 0 comments Download
M test/cctest/test-assembler-x64.cc View 2 chunks +98 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 10 months ago (2015-02-06 12:16:04 UTC) #1
Benedikt Meurer
PTAL
5 years, 10 months ago (2015-02-06 12:16:22 UTC) #2
dcarney
lgtm
5 years, 10 months ago (2015-02-06 12:17:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887013003/1
5 years, 10 months ago (2015-02-06 12:18:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 12:48:23 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 12:49:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/008f4732f78f71d8d37bc574b75d5bccff94025b
Cr-Commit-Position: refs/heads/master@{#26486}

Powered by Google App Engine
This is Rietveld 408576698