Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 887003007: Revert of Add Autofill to webview (Closed)

Created:
5 years, 10 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, lazyboy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add Autofill to webview (patchset #5 id:160001 of https://codereview.chromium.org/866523002/) Reason for revert: BUG=456215 Original issue's description: > Add Autofill to webview > > The change in the chrome_autofill_client.cc is needed to enable the autofill popup on > Mac. > > BUG=447938 > TEST=Start Chrome. Navigate to chrome://chrome-signin. Enter a correct username > with an incorrect password. After the password error appears, you should be able > to autofill that username. > > Committed: https://crrev.com/4a1e13b16b5ef2cb6f7c800ad3c08f1f44bef285 > Cr-Commit-Position: refs/heads/master@{#314889} TBR=estade@chromium.org,fsamuel@chromium.org,lazyboy@chromium.org,noms@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=447938 Committed: https://crrev.com/a5b2fc98fd625f082bf00758571f476c7ae67dc4 Cr-Commit-Position: refs/heads/master@{#315122}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -22 lines) Patch
M chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc View 2 chunks +1 line, -15 lines 0 comments Download
M chrome/browser/ui/autofill/chrome_autofill_client.cc View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Vitaly Buka (NO REVIEWS)
Created Revert of Add Autofill to webview
5 years, 10 months ago (2015-02-06 22:28:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887003007/1
5 years, 10 months ago (2015-02-06 22:29:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 22:30:36 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 22:31:24 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5b2fc98fd625f082bf00758571f476c7ae67dc4
Cr-Commit-Position: refs/heads/master@{#315122}

Powered by Google App Engine
This is Rietveld 408576698