Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: toolchain_build/toolchain_build_pnacl.py

Issue 886943004: Update trusted clang from 209387 to 223109. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: disable warning while building llvm 3.5 for now Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: toolchain_build/toolchain_build_pnacl.py
diff --git a/toolchain_build/toolchain_build_pnacl.py b/toolchain_build/toolchain_build_pnacl.py
index 6a0eb21f667250daa059345858110bb6d1ad315e..c5f54973f6a520b4312b063e00f3d5d492822f42 100755
--- a/toolchain_build/toolchain_build_pnacl.py
+++ b/toolchain_build/toolchain_build_pnacl.py
@@ -225,6 +225,11 @@ def ConfigureHostArchFlags(host, extra_cflags, options, extra_configure=None):
configure_args.extend(['CFLAGS=' + ' '.join(extra_cflags),
'CXXFLAGS=' + ' '.join(extra_cflags)])
else:
+ # TODO(jvoung): Remove this after merging LLVM to be cleaner
+ # w.r.t. -Winconsistent-missing-override.
+ # https://code.google.com/p/nativeclient/issues/detail?id=4026
+ if not options.gcc:
+ extra_cflags.append('-Wno-inconsistent-missing-override')
configure_args.extend(
['CFLAGS=' + ' '.join(extra_cflags),
'LDFLAGS=-L%(' + GSDJoin('abs_libcxx', host) + ')s/lib',
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698