Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 886943004: Update trusted clang from 209387 to 223109. (Closed)

Created:
5 years, 10 months ago by jvoung (off chromium)
Modified:
5 years, 10 months ago
Reviewers:
bradnelson, bradn, JF
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Update trusted clang from 209387 to 223109. Newer than what we have and will at least match the upcoming PNaCl clang revision after merging. Otherwise, the old trusted 209387 clang currently crashes while trying to compile to compile LLVM unittests from 223109 when paired with libc++ at ~223109. The MakeUniqueTest will crash the 209387 clang. Had to disable a new clang warning for now. Too much upstream LLVM code that violates it. Will re-enable after merging. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4026 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/df23dd238cbe460892fea8522d7b25ddb6bb57bb

Patch Set 1 #

Patch Set 2 : disable warning while building llvm 3.5 for now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M toolchain_build/toolchain_build_pnacl.py View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jvoung (off chromium)
Didn't test the asan bots yet, but have a separate CL for that https://codereview.chromium.org/894413002/
5 years, 10 months ago (2015-02-03 18:01:20 UTC) #2
JF
lgtm
5 years, 10 months ago (2015-02-03 18:26:26 UTC) #3
bradn
lgtm
5 years, 10 months ago (2015-02-03 18:28:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886943004/20001
5 years, 10 months ago (2015-02-03 19:12:31 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 21:23:48 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/native_client/src/native_client/+/df23dd238...

Powered by Google App Engine
This is Rietveld 408576698