Move documentScan.html from extensions to apps

Move documentScan.html from extensions to apps

BUG=450601
R=kalman@chromium.org

Committed: https://crrev.com/67610e1eaa5341fd996ed693e2d843524d9ce84d
Cr-Commit-Position: refs/heads/master@{#314423}

[not at google - send to devlin, 2015-02-03 18:22:17]

Move isn't right, it's available to both extensions and apps, see

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/exte...

so leave the extensions one, then when you add a new apps one substitute
"extension" for  "app" in the content as well.

https://codereview.chromium.org/886943003/diff/2/chrome/common/extensions/api...
File chrome/common/extensions/api/document_scan.idl (right):

https://codereview.chromium.org/886943003/diff/2/chrome/common/extensions/api...
chrome/common/extensions/api/document_scan.idl:26: // the results from the scan
is returned in |results|.
2 things: "results" was fine, but also, this will need to <code>results</code>.

However, try this:

// Callback from the <code>scan</code> method.
// |results| The results from the scan, if successful.
// Otherwise, will return [what? empty results? null] and set
// runtime.lastError.

see how it renders (chrome/common/extensions/docs/server2/preview.py). I can't
remember what it will look like.

[Paul Stewart, 2015-02-03 21:43:12]

PTAL, thanks.

https://codereview.chromium.org/886943003/diff/2/chrome/common/extensions/api...
File chrome/common/extensions/api/document_scan.idl (right):

https://codereview.chromium.org/886943003/diff/2/chrome/common/extensions/api...
chrome/common/extensions/api/document_scan.idl:26: // the results from the scan
is returned in |results|.
On 2015/02/03 18:22:17, kalman wrote:
> 2 things: "results" was fine, but also, this will need to
<code>results</code>.

I'm trying to satisfy commentary I'm getting in parallel from
http://crbug.com/450601 .  Feel free to intervene in that discussion if you feel
strongly.
> 
> However, try this:
> 
> // Callback from the <code>scan</code> method.
> // |results| The results from the scan, if successful.
> // Otherwise, will return [what? empty results? null] and set
> // runtime.lastError.
> 
> see how it renders (chrome/common/extensions/docs/server2/preview.py). I can't
> remember what it will look like.

Done.  Makes no difference due to how the comments are generated for inlines.

[not at google - send to devlin, 2015-02-03 21:58:43]

lgtm with one more change

https://codereview.chromium.org/886943003/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/public/apps/documentScan.html
(right):

https://codereview.chromium.org/886943003/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/public/apps/documentScan.html:1:
{{+partials.standard_extensions_api api:apis.extensions.document_scan
intro:intros.documentScan/}}
s/extensions/apps/g

[Paul Stewart, 2015-02-03 22:02:39]

New patchsets have been uploaded after l-g-t-m from kalman@chromium.org

[Paul Stewart, 2015-02-03 22:03:15]

On 2015/02/03 21:58:43, kalman wrote:
> lgtm with one more change
> 
>
https://codereview.chromium.org/886943003/diff/20001/chrome/common/extensions...
> File chrome/common/extensions/docs/templates/public/apps/documentScan.html
> (right):
> 
>
https://codereview.chromium.org/886943003/diff/20001/chrome/common/extensions...
> chrome/common/extensions/docs/templates/public/apps/documentScan.html:1:
> {{+partials.standard_extensions_api api:apis.extensions.document_scan
> intro:intros.documentScan/}}
> s/extensions/apps/g

Done

[Paul Stewart, 2015-02-03 22:04:04]

The CQ bit was checked by pstew@chromium.org

[commit-bot: I haz the power, 2015-02-03 22:05:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/886943003/40001

[commit-bot: I haz the power, 2015-02-03 22:51:02]

Committed patchset #4 (id:40001)

[commit-bot: I haz the power, 2015-02-03 22:51:49]

Patchset 4 (id:??) landed as
https://crrev.com/67610e1eaa5341fd996ed693e2d843524d9ce84d
Cr-Commit-Position: refs/heads/master@{#314423}