Issue 886933006: Revert of Mac Video Capture: Add support for pixel format NV12 for AVFoundation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 886933006: Revert of Mac Video Capture: Add support for pixel format NV12 for AVFoundation (Closed)

Created:
5 years, 10 months ago by magjed_chromium

Modified:
5 years, 10 months ago

Reviewers:
perkj_chrome, mcasas, tommi (sloooow) - chröme

CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Mac Video Capture: Add support for pixel format NV12 for AVFoundation (patchset #2 id:60001 of https://codereview.chromium.org/860333003/) Reason for revert: Crashes on the assert that biplanar NV12 is tightly packed. BUG=455618 Original issue's description: > Mac Video Capture: Add support for pixel format NV12 for AVFoundation > > BUG=346634 > > Committed: https://crrev.com/40c2c94fbd52f9748ee082573e07404ae2621b9b > Cr-Commit-Position: refs/heads/master@{#313886} TBR=perkj@chromium.org,tommi@chromium.org,mcasas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=346634 Committed: https://crrev.com/e0f4e10eaf18c3082549578ece777a40884bf9d2 Cr-Commit-Position: refs/heads/master@{#314788}

Created: 5 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -28 lines)			Patch
	M	media/video/capture/mac/video_capture_device_avfoundation_mac.mm	View		3 chunks	+3 lines, -28 lines	0 comments	Download

Total messages: 4 (0 generated)

magjed_chromium

Created Revert of Mac Video Capture: Add support for pixel format NV12 for AVFoundation

5 years, 10 months ago (2015-02-05 10:54:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886933006/1

5 years, 10 months ago (2015-02-05 10:55:38 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-05 10:57:20 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e0f4e10eaf18c3082549578ece777a40884bf9d2
Cr-Commit-Position: refs/heads/master@{#314788}