Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issue 886933002: Remove PaintPhaseSelection. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove PaintPhaseSelection. This is just a mechanical removal. No logic changes beyond removing the PaintPhaseSelection checks. Most of these are just early returns to avoid doing unnecessary work if we're only painting selections. But now that we paint selections during the foreground paint phase, we no longer need the early returns since we're going to paint everything anyways. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b6195dc897a9e49d3b8de220b57a8468436ebcb3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -43 lines) Patch
M sky/engine/core/rendering/InlineTextBox.cpp View 6 chunks +25 lines, -34 lines 0 comments Download
M sky/engine/core/rendering/PaintPhase.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderReplaced.cpp View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
esprehn
lgtm
5 years, 10 months ago (2015-01-30 01:00:35 UTC) #2
ojan
5 years, 10 months ago (2015-01-30 01:18:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b6195dc897a9e49d3b8de220b57a8468436ebcb3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698