site/dev/contrib/c++11.md - Issue 886913004: turns out the newlines matter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: site/dev/contrib/c++11.md

Issue 886913004: turns out the newlines matter (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: site/dev/contrib/c++11.md

diff --git a/site/dev/contrib/c++11.md b/site/dev/contrib/c++11.md

index cad2efae5f9db2ebf42431064898c50858ca1383..4f175b302a484473c578a788f69f055387381628 100644

--- a/site/dev/contrib/c++11.md

+++ b/site/dev/contrib/c++11.md

@@ -9,6 +9,7 @@ document is not concerned with C++11 policy in Skia, only its technical

feasibility. This is about what we can use, a superset of what we may use.

The gist:

- C++11 the language as supported by GCC 4.4 or later is probably usable.

- If you break a bot, that feature is not usable.

- The C++11 standard library can't generally be used.

@@ -59,6 +60,7 @@ Chrome's toolchains (see above). I'm not exactly sure what our Chrome OS bots

are using, but they've never been a problem.

A few miscellaneous compile-only bots are actually our current overall weak link:

- Our NaCl builds use an old non-PNaCl toolchain, which is based on GCC

4.4. GCC 4.4 has some support for C++11, but it's not nearly complete.

There is no upgrade path except PNaCl; even the very latest NaCl toolchain

« no previous file with comments | « no previous file | no next file » | no next file with comments »