Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: remoting/host/it2me/it2me_host.cc

Issue 886913002: Always run PolicyWatcher on UI thread in It2Me host. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/it2me/it2me_host.cc
diff --git a/remoting/host/it2me/it2me_host.cc b/remoting/host/it2me/it2me_host.cc
index e5e6196803862eff219fc098678a45d874c3787f..9b547ade733749b113c1b31c5b1e73e77a5bb4b2 100644
--- a/remoting/host/it2me/it2me_host.cc
+++ b/remoting/host/it2me/it2me_host.cc
@@ -298,14 +298,6 @@ void It2MeHost::ShutdownOnUiThread() {
desktop_environment_factory_.reset();
// Stop listening for policy updates.
- if (policy_watcher_.get()) {
- policy_watcher_->StopWatching(
- base::Bind(&It2MeHost::OnPolicyWatcherShutdown, this));
- return;
- }
-}
-
-void It2MeHost::OnPolicyWatcherShutdown() {
policy_watcher_.reset();
}
@@ -356,8 +348,7 @@ void It2MeHost::OnClientDisconnected(const std::string& jid) {
}
void It2MeHost::OnPolicyUpdate(scoped_ptr<base::DictionaryValue> policies) {
- // The policy watcher runs on the |ui_task_runner| on ChromeOS and the
- // |network_task_runner| on other platforms.
+ // The policy watcher runs on the |ui_task_runner|.
if (!host_context_->network_task_runner()->BelongsToCurrentThread()) {
host_context_->network_task_runner()->PostTask(
FROM_HERE,
@@ -532,11 +523,13 @@ scoped_refptr<It2MeHost> It2MeHostFactory::CreateIt2MeHost(
base::WeakPtr<It2MeHost::Observer> observer,
const XmppSignalStrategy::XmppServerConfig& xmpp_server_config,
const std::string& directory_bot_jid) {
+ DCHECK(context->ui_task_runner()->BelongsToCurrentThread());
+
scoped_ptr<It2MeConfirmationDialogFactory> confirmation_dialog_factory(
new It2MeConfirmationDialogFactory());
scoped_ptr<policy_hack::PolicyWatcher> policy_watcher =
policy_hack::PolicyWatcher::Create(policy_service_,
- context->network_task_runner());
+ context->file_task_runner());
return new It2MeHost(context.Pass(), policy_watcher.Pass(),
confirmation_dialog_factory.Pass(),
observer, xmpp_server_config, directory_bot_jid);

Powered by Google App Engine
This is Rietveld 408576698