Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 886903002: Slightly changed top-level redirect test (Closed)

Created:
5 years, 10 months ago by mkearney1
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Slightly changed top-level redirect test This test should pass, allowing extensions/index to redirect to extensions. Committed: https://crrev.com/13d20aa601d2c339304237327d5b5485673267aa Cr-Commit-Position: refs/heads/master@{#313989}

Patch Set 1 #

Patch Set 2 : Removed extra white spaces #

Patch Set 3 : Fixed integration test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M chrome/common/extensions/docs/server2/integration_test.py View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/render_servlet_test.py View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mkearney1
This should fix the broken test without having to roll-back my fix. Ran the script ...
5 years, 10 months ago (2015-01-29 23:19:01 UTC) #2
not at google - send to devlin
lgtm
5 years, 10 months ago (2015-01-29 23:29:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886903002/20001
5 years, 10 months ago (2015-01-29 23:37:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/39312)
5 years, 10 months ago (2015-01-30 00:15:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886903002/40001
5 years, 10 months ago (2015-01-30 20:12:47 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-30 20:52:26 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 20:54:02 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/13d20aa601d2c339304237327d5b5485673267aa
Cr-Commit-Position: refs/heads/master@{#313989}

Powered by Google App Engine
This is Rietveld 408576698