Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8869005: Revert EnableClose() removal and related crash fixes. I don't understand the crashes here, and th... (Closed)

Created:
9 years ago by Ben Goodger (Google)
Modified:
9 years ago
Reviewers:
sky
CC:
chromium-reviews, msw+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, prasadt, dhollowa+watch_chromium.org, Paweł Hajdan Jr., jam, Dmitry Titov, dcheng, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, jennb, darin-cc_chromium.org, jianli, tfarina, alicet1, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert EnableClose() removal and related crash fixes. I don't understand the crashes here, and this isn't important enough for me to be wasting time on. Brian says they may tweak this UI sometime soon, so if that happens we can try removing this API again. BUG=106078 TEST=none

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -229 lines) Patch
M chrome/browser/chromeos/frame/bubble_frame_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/frame/bubble_frame_view.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_frame_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_frame_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/first_run_search_engine_view.h View 6 chunks +4 lines, -37 lines 0 comments Download
M chrome/browser/ui/views/first_run_search_engine_view.cc View 8 chunks +24 lines, -63 lines 0 comments Download
D chrome/browser/ui/views/first_run_search_engine_view_unittest.cc View 1 chunk +0 lines, -109 lines 0 comments Download
M chrome/browser/ui/views/frame/app_panel_browser_frame_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/app_panel_browser_frame_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/popup_non_client_frame_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/popup_non_client_frame_view.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/base/testing_profile.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M content/browser/gamepad/data_fetcher_win.cc View 2 chunks +3 lines, -0 lines 1 comment Download
M ui/aura_shell/toplevel_frame_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura_shell/toplevel_frame_view.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M ui/views/bubble/bubble_frame_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/test/views_test_base.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_gtk.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_gtk.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_private.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_win.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/views/widget/widget.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/views/window/custom_frame_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/window/custom_frame_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/window/native_frame_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/window/native_frame_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/window/non_client_view.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/views/window/non_client_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
Sadness.
9 years ago (2011-12-07 23:30:21 UTC) #1
sky
9 years ago (2011-12-08 00:04:21 UTC) #2 
http://codereview.chromium.org/8869005/diff/1/content/browser/gamepad/data_fe...
File content/browser/gamepad/data_fetcher_win.cc (right):

http://codereview.chromium.org/8869005/diff/1/content/browser/gamepad/data_fe...
content/browser/gamepad/data_fetcher_win.cc:69: /*
Is this intentional?

Powered by Google App Engine
This is Rietveld 408576698