Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 886873003: Make DisplayInfo::Copy() copy over DisplayInfo::is_aspect_preserving_scaling_ (Closed)

Created:
5 years, 10 months ago by pkotwicz
Modified:
5 years, 10 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make DisplayInfo::Copy() copy over DisplayInfo::is_aspect_preserving_scaling_ BUG=453200 TEST=Manual, see bug Committed: https://crrev.com/941a3b51fea40279bc555963d7a32d7ed94a952f Cr-Commit-Position: refs/heads/master@{#313968}

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M ash/display/display_info.h View 1 chunk +2 lines, -0 lines 1 comment Download
M ash/display/display_info.cc View 2 chunks +5 lines, -9 lines 1 comment Download

Messages

Total messages: 9 (4 generated)
pkotwicz
Oshima, PTAL I couldn't think of a good test for this CL. (I was hoping ...
5 years, 10 months ago (2015-01-29 20:37:59 UTC) #4
oshima
https://codereview.chromium.org/886873003/diff/40001/ash/display/display_info.h File ash/display/display_info.h (right): https://codereview.chromium.org/886873003/diff/40001/ash/display/display_info.h#newcode283 ash/display/display_info.h:283: // If you add a new member, you need ...
5 years, 10 months ago (2015-01-30 18:06:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886873003/40001
5 years, 10 months ago (2015-01-30 19:03:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 10 months ago (2015-01-30 20:04:35 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 20:06:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/941a3b51fea40279bc555963d7a32d7ed94a952f
Cr-Commit-Position: refs/heads/master@{#313968}

Powered by Google App Engine
This is Rietveld 408576698