Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: chrome/browser/resources/options/browser_options.js

Issue 886843002: options/guest mode: only hide the 'Show advanced settings...' link when (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: best Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.exportPath('options'); 5 cr.exportPath('options');
6 6
7 /** 7 /**
8 * @typedef {{actionLinkText: (string|undefined), 8 * @typedef {{actionLinkText: (string|undefined),
9 * childUser: (boolean|undefined), 9 * childUser: (boolean|undefined),
10 * hasError: (boolean|undefined), 10 * hasError: (boolean|undefined),
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 // section (rather than hiding it), focus the first element in the 133 // section (rather than hiding it), focus the first element in the
134 // container. 134 // container.
135 if (e.detail == 0 && showAdvanced) { 135 if (e.detail == 0 && showAdvanced) {
136 var focusElement = $('advanced-settings-container').querySelector( 136 var focusElement = $('advanced-settings-container').querySelector(
137 'button, input, list, select, a[href]'); 137 'button, input, list, select, a[href]');
138 if (focusElement) 138 if (focusElement)
139 focusElement.focus(); 139 focusElement.focus();
140 } 140 }
141 }; 141 };
142 } else { 142 } else {
143 $('advanced-settings-expander').hidden = true; 143 $('advanced-settings-footer').hidden = true;
144 $('advanced-settings').hidden = true; 144 $('advanced-settings').hidden = true;
145 } 145 }
146 146
147 $('advanced-settings').addEventListener('webkitTransitionEnd', 147 $('advanced-settings').addEventListener('webkitTransitionEnd',
148 this.updateAdvancedSettingsExpander_.bind(this)); 148 this.updateAdvancedSettingsExpander_.bind(this));
149 149
150 if (loadTimeData.getBoolean('showAbout')) { 150 if (loadTimeData.getBoolean('showAbout')) {
151 $('about-button').hidden = false; 151 $('about-button').hidden = false;
152 $('about-button').addEventListener('click', function() { 152 $('about-button').addEventListener('click', function() {
153 PageManager.showPageByName('help'); 153 PageManager.showPageByName('help');
(...skipping 2048 matching lines...) Expand 10 before | Expand all | Expand 10 after
2202 } 2202 }
2203 button.textContent = loadTimeData.getString(strId); 2203 button.textContent = loadTimeData.getString(strId);
2204 }; 2204 };
2205 } 2205 }
2206 2206
2207 // Export 2207 // Export
2208 return { 2208 return {
2209 BrowserOptions: BrowserOptions 2209 BrowserOptions: BrowserOptions
2210 }; 2210 };
2211 }); 2211 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698