Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1424)

Issue 886833006: X87: Reland "Initial switch to Chromium-style CHECK_* and DCHECK_* macros (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Reland "Initial switch to Chromium-style CHECK_* and DCHECK_* macros port c65ae4f10c7273956e88db433f626b26a1377caf (r26346). fix one spelling error introduced by this CL. original commit message: Reland "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". BUG= Committed: https://crrev.com/13d6a96a8fe9aa171108d8018683978657f4f656 Cr-Commit-Position: refs/heads/master@{#26507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 10 months ago (2015-02-09 05:43:25 UTC) #2
Weiliang
lgtm
5 years, 10 months ago (2015-02-09 05:45:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886833006/1
5 years, 10 months ago (2015-02-09 05:46:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 06:08:51 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 06:09:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13d6a96a8fe9aa171108d8018683978657f4f656
Cr-Commit-Position: refs/heads/master@{#26507}

Powered by Google App Engine
This is Rietveld 408576698