Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 886813002: Remove SkProxyCanvas. (Closed)

Created:
5 years, 10 months ago by scroggo
Modified:
5 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SkProxyCanvas. SkProxyCanvas is redundant with SkNWayCanvas, and means another class we have to keep in sync with the SkCanvas interface. Remove tests which use an SkProxyCanvas. Requires a change to chromium. BUG=skia:3279 BUG=skia:500 Committed: https://skia.googlesource.com/skia/+/648238cc900994de79c9e7d17f755661222aa52f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -318 lines) Patch
M gyp/utils.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
D include/utils/SkProxyCanvas.h View 1 chunk +0 lines, -92 lines 0 comments Download
D src/utils/SkProxyCanvas.cpp View 1 chunk +0 lines, -186 lines 0 comments Download
M tests/CanvasTest.cpp View 6 chunks +1 line, -38 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
scroggo
5 years, 10 months ago (2015-01-29 14:38:00 UTC) #2
mtklein
LGTM LGTM LGTM!
5 years, 10 months ago (2015-01-29 15:12:09 UTC) #4
reed1
lgtm
5 years, 10 months ago (2015-01-29 15:57:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886813002/1
5 years, 10 months ago (2015-01-29 19:15:49 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 19:58:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/648238cc900994de79c9e7d17f755661222aa52f

Powered by Google App Engine
This is Rietveld 408576698