Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 886753002: Re-layout list view and add thumbnails for each files. (Closed)

Created:
5 years, 10 months ago by fukino
Modified:
5 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-layout list view and add thumbnails for each files. Changes are: - Changes layout of list view. - Add thumbnails for each files. - Add checkmarks for selected items. - Selected items' colors are not inverted to blue now. BUG=402344 TEST=run browser_tests Committed: https://crrev.com/7529a7ac7bcf123222459fc2892f85379ff4643a Cr-Commit-Position: refs/heads/master@{#313863}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -122 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 3 chunks +45 lines, -21 lines 0 comments Download
M ui/file_manager/file_manager/foreground/css/file_types.css View 1 30 chunks +2 lines, -100 lines 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/2x/list_checked.png View 1 2 Binary file 0 comments Download
M ui/file_manager/file_manager/foreground/images/files/ui/2x/thumbnail_checked.png View 1 2 Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/list_checked.png View 1 2 Binary file 0 comments Download
M ui/file_manager/file_manager/foreground/images/files/ui/thumbnail_checked.png View 1 2 Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/white_archive.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/white_downloads.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/white_drive.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/white_hdd.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/white_offline.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/white_optical.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/white_phone.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/white_recent.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/white_sd.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/white_shared.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/white_usb.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/white_archive.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/white_downloads.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/white_drive.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/white_hdd.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/white_offline.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/white_optical.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/white_phone.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/white_recent.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/white_sd.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/white_shared.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/white_usb.png View Binary file 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_table.js View 1 2 2 chunks +45 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
fukino
PTAL. Thank you!
5 years, 10 months ago (2015-01-29 09:14:10 UTC) #2
hirono
Please optimize the size of new pngs if you haven't yet. https://codereview.chromium.org/886753002/diff/20001/ui/file_manager/file_manager/foreground/js/ui/file_table.js File ui/file_manager/file_manager/foreground/js/ui/file_table.js (right): ...
5 years, 10 months ago (2015-01-29 09:21:49 UTC) #3
fukino
> Please optimize the size of new pngs if you haven't yet. I've optimizer for ...
5 years, 10 months ago (2015-01-29 12:01:38 UTC) #4
hirono
lgtm!
5 years, 10 months ago (2015-01-30 01:06:56 UTC) #5
fukino
On 2015/01/30 01:06:56, hirono wrote: > lgtm! Thanks!
5 years, 10 months ago (2015-01-30 02:48:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886753002/40001
5 years, 10 months ago (2015-01-30 02:49:24 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-30 03:25:08 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 03:26:03 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7529a7ac7bcf123222459fc2892f85379ff4643a
Cr-Commit-Position: refs/heads/master@{#313863}

Powered by Google App Engine
This is Rietveld 408576698