Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 886733005: [turbofan] OSR loops assign all local variables. (Closed)

Created:
5 years, 10 months ago by titzer
Modified:
5 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] OSR loops assign all local variables. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/d9892bbd5a78b5a1e389cbf4854ec7fcbd645567 Cr-Commit-Position: refs/heads/master@{#26493}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/bit-vector.h View 1 chunk +2 lines, -0 lines 2 comments Download
M src/compiler/ast-loop-assignment-analyzer.cc View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (1 generated)
titzer
5 years, 10 months ago (2015-02-06 14:07:47 UTC) #1
Michael Starzinger
LGTM. Sigh ... :/ https://codereview.chromium.org/886733005/diff/1/src/bit-vector.h File src/bit-vector.h (right): https://codereview.chromium.org/886733005/diff/1/src/bit-vector.h#newcode157 src/bit-vector.h:157: for (int i = 0; ...
5 years, 10 months ago (2015-02-06 14:59:32 UTC) #2
titzer
https://codereview.chromium.org/886733005/diff/1/src/bit-vector.h File src/bit-vector.h (right): https://codereview.chromium.org/886733005/diff/1/src/bit-vector.h#newcode157 src/bit-vector.h:157: for (int i = 0; i < data_length_; i++) ...
5 years, 10 months ago (2015-02-06 15:01:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886733005/1
5 years, 10 months ago (2015-02-06 15:04:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 15:57:04 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 15:57:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9892bbd5a78b5a1e389cbf4854ec7fcbd645567
Cr-Commit-Position: refs/heads/master@{#26493}

Powered by Google App Engine
This is Rietveld 408576698