Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 886713006: Apply prePathMatrix in SkGpuDevice as view matrix preconcat when possible (Closed)

Created:
5 years, 10 months ago by bsalomon
Modified:
5 years, 10 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Apply prePathMatrix in SkGpuDevice as view matrix preconcat when possible BUG=skia:3055 Committed: https://skia.googlesource.com/skia/+/54443932e86812258eda6ec23d0a0827822edf19

Patch Set 1 #

Patch Set 2 : formatting #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -24 lines) Patch
M src/gpu/SkGpuDevice.cpp View 1 6 chunks +31 lines, -24 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
bsalomon
5 years, 10 months ago (2015-01-29 15:59:13 UTC) #2
bsalomon
https://codereview.chromium.org/886713006/diff/20001/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (left): https://codereview.chromium.org/886713006/diff/20001/src/gpu/SkGpuDevice.cpp#oldcode784 src/gpu/SkGpuDevice.cpp:784: // The context's matrix may change while creating the ...
5 years, 10 months ago (2015-01-29 15:59:51 UTC) #3
jvanverth1
lgtm
5 years, 10 months ago (2015-01-29 17:02:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886713006/20001
5 years, 10 months ago (2015-01-29 17:29:01 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 17:34:22 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/54443932e86812258eda6ec23d0a0827822edf19

Powered by Google App Engine
This is Rietveld 408576698