Issue 886683002: Add a selection and outline to flights-app.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 886683002: Add a selection and outline to flights-app. (Closed)

Created:
5 years, 10 months ago by ojan

Modified:
5 years, 10 months ago

Reviewers:
esprehn, abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add a selection and outline to flights-app. This is just to get basic paint coverage of selections and outlines on positioned elements. TBR=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5e214a9ecf298c1483d8cb33313cc04f7bc1aebf

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -1 line)			Patch
M	sky/examples/flights-app/app-search-input.sky	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sky/examples/flights-app/app-toast.sky	View	2 chunks	+13 lines, -0 lines	0 comments	Download
M	sky/tests/framework/flights-app-expected.txt	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	sky/tests/framework/flights-app-pixels-expected.sky	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (1 generated)

ojan

Committed patchset #1 (id:1) manually as 5e214a9ecf298c1483d8cb33313cc04f7bc1aebf (presubmit successful).

5 years, 10 months ago (2015-01-29 05:48:33 UTC) #1

Message was sent while issue was closed.

lgtm