Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: chrome/browser/android/banners/app_banner_manager.h

Issue 886643003: Use heuristic to work out when to prompt for app install banners. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review feedback Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/banners/app_banner_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/banners/app_banner_manager.h
diff --git a/chrome/browser/android/banners/app_banner_manager.h b/chrome/browser/android/banners/app_banner_manager.h
index c333bcb555399187596406be0486df00bb227771..b82ec7afe3273b6cfdf0fa6ad18eddb4559b5c39 100644
--- a/chrome/browser/android/banners/app_banner_manager.h
+++ b/chrome/browser/android/banners/app_banner_manager.h
@@ -138,6 +138,13 @@ class AppBannerManager : public chrome::BitmapFetcherDelegate,
// Called when the result of the CheckHasServiceWorker query has completed.
void OnDidCheckHasServiceWorker(bool has_service_worker);
+ // Record that the banner could be shown at this point, if the triggering
+ // heuristic allowed.
+ void RecordCouldShowBanner(const std::string& package_or_start_url);
+
+ // Check if the banner should be shown.
+ bool CheckIfShouldShow(const std::string& package_or_start_url);
+
// Fetches the icon for an app.
scoped_ptr<chrome::BitmapFetcher> fetcher_;
GURL validated_url_;
« no previous file with comments | « no previous file | chrome/browser/android/banners/app_banner_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698