Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 886633007: Always force swap for SurfaceDisplayOutputSurface. (Closed)

Created:
5 years, 10 months ago by jbauman
Modified:
5 years, 10 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always force swap for SurfaceDisplayOutputSurface. Force reclaim clears out the Surface's copy of the delegated frame, so a swap is always necessary to restore its contents. Committed: https://crrev.com/e3c79bdf0c63955eeeef57621bfb07ec19fb7935 Cr-Commit-Position: refs/heads/master@{#314492}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M cc/surfaces/surface_display_output_surface.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jbauman
5 years, 10 months ago (2015-02-04 00:22:44 UTC) #2
jamesr
Maybe I'm being mislead about the setting name, but does this mean we swap even ...
5 years, 10 months ago (2015-02-04 01:30:18 UTC) #3
jbauman
On 2015/02/04 01:30:18, jamesr wrote: > Maybe I'm being mislead about the setting name, but ...
5 years, 10 months ago (2015-02-04 01:32:34 UTC) #4
jamesr
Right, gotcha. This is confusing. IMHO we should decouple the "OutputSurface that actually just gives ...
5 years, 10 months ago (2015-02-04 02:30:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886633007/1
5 years, 10 months ago (2015-02-04 02:31:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 03:34:35 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 03:35:40 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3c79bdf0c63955eeeef57621bfb07ec19fb7935
Cr-Commit-Position: refs/heads/master@{#314492}

Powered by Google App Engine
This is Rietveld 408576698