Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart

Issue 886633003: Fix remaining uses of lookupConstructor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart
index ec796daf3d29d74fb274d958737410c8a20b0a4c..1287973fb69bbfbee29c066e9a1ea81f82122187 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart
@@ -237,13 +237,12 @@ abstract class IrBuilderVisitor extends ResolvedVisitor<ir.Primitive>
ClassElement enclosingClass = element.enclosingClass;
if (!enclosingClass.isObject) {
ClassElement superClass = enclosingClass.superclass;
- Selector selector =
- new Selector.callDefaultConstructor(enclosingClass.library);
- FunctionElement target = superClass.lookupConstructor(selector);
+ FunctionElement target = superClass.lookupDefaultConstructor();
if (target == null) {
compiler.internalError(superClass,
"No default constructor available.");
}
+ Selector selector = new Selector.fromElement(target);
result.add(irBuilder.makeSuperInitializer(target,
<ir.RunnableBody>[],
selector));
@@ -1372,9 +1371,7 @@ class JsIrBuilderVisitor extends IrBuilderVisitor {
// If no super() or this() was found, also call default superconstructor.
if (!hasConstructorCall && !enclosingClass.isObject) {
ClassElement superClass = enclosingClass.superclass;
- Selector selector =
- new Selector.callDefaultConstructor(enclosingClass.library);
- FunctionElement target = superClass.lookupConstructor(selector);
+ FunctionElement target = superClass.lookupDefaultConstructor();
if (target == null) {
compiler.internalError(superClass, "No default constructor available.");
}
« no previous file with comments | « no previous file | pkg/compiler/lib/src/resolution/members.dart » ('j') | tests/compiler/dart2js/resolver_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698