Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3687)

Unified Diff: chrome/app/chrome_watcher_client_win.h

Issue 886613002: Introduce the ability to wait for the watcher process to initialize. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/chrome_watcher_client_win.h
diff --git a/chrome/app/chrome_watcher_client_win.h b/chrome/app/chrome_watcher_client_win.h
new file mode 100644
index 0000000000000000000000000000000000000000..59af606372432c9feff7e7af0cb83722933b0998
--- /dev/null
+++ b/chrome/app/chrome_watcher_client_win.h
@@ -0,0 +1,65 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_APP_CHROME_WATCHER_CLIENT_WIN_H_
+#define CHROME_APP_CHROME_WATCHER_CLIENT_WIN_H_
+
+#include <windows.h>
+
+#include "base/callback.h"
+#include "base/command_line.h"
+#include "base/macros.h"
+#include "base/process/process.h"
+#include "base/win/scoped_handle.h"
+
+// Launches a Chrome watcher process and permits the client to wait until the
+// process is fully initialized.
+class ChromeWatcherClient {
+ public:
+ // A CommandLineGenerator generates command lines that will launch a separate
+ // process and pass the supplied HANDLEs to WatcherMain in that process. The
+ // first HANDLE is an event that should be signaled when the watcher process
+ // is fully initialized. The second HANDLE is the process that the watcher
Sigurður Ásgeirsson 2015/01/29 16:59:56 note that both handles must be inheritable? Maybe
erikwright (departed) 2015/01/30 20:39:57 Given that the command-line generator is not respo
+ // process should watch.
+ typedef base::Callback<base::CommandLine(HANDLE, HANDLE)>
+ CommandLineGenerator;
+
+ // Constructs an instance that launches its watcher process using the command
+ // line generated by |command_line_generator|.
+ explicit ChromeWatcherClient(
+ const CommandLineGenerator& command_line_generator);
+
+ ~ChromeWatcherClient();
+
+ // Launches the watcher process such that the child process is able to inherit
+ // a handle to the current process. Returns true if the process is
+ // successfully launched.
+ bool LaunchWatcher();
+
+ // Blocks until the process, previously launched by LaunchWatcher, is either
+ // fully initialized or terminates. Returns true if the process successfully
+ // initializes.
+ bool WaitForInitialization();
+
+ // Terminates the previously launched watcher process with |exit_code| if it
+ // has not already exited. Blocks until the process has exited and returns its
Sigurður Ásgeirsson 2015/01/29 16:59:57 This is hopefully for testing only?
erikwright (departed) 2015/01/30 20:39:57 Yes, although I can't think of a good reason to la
Sigurður Ásgeirsson 2015/02/02 16:59:20 Not the way it's currently implemented. TerminateP
erikwright (departed) 2015/02/03 20:05:34 How about this? It's up to the client to ask the "
+ // exit code. Note that the return value might differ from |exit_code| if, for
+ // example, it exits naturally before the forced termination takes place. The
+ // return value is undefined if LaunchWatcher has not been called or failed,
+ // or if invoked multiple times.
+ int TerminateWatcher(int exit_code);
+
+ // Returns true if the process has previously been launched and
+ // TerminateWatcher has not yet been invoked.
+ bool launched() { return process_.IsValid(); }
+
+ private:
+ CommandLineGenerator command_line_generator_;
+ base::win::ScopedHandle on_initialized_event_;
+ base::Process process_;
+
+ DISALLOW_COPY_AND_ASSIGN(ChromeWatcherClient);
+};
+
+#endif // CHROME_APP_CHROME_WATCHER_CLIENT_WIN_H_

Powered by Google App Engine
This is Rietveld 408576698