content/browser/web_contents/web_contents_impl.cc - Issue 886603009: Cleanup power save blockers after a RenderView crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 886603009: Cleanup power save blockers after a RenderView crashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_impl_unittest.cc » ('j') | content/browser/web_contents/web_contents_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index f4837942137d3f8fee9676a5a70e8b8a03695c87..c6672bc381c392389bce4924363453905abf19a9 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -3702,6 +3702,10 @@ void WebContentsImpl::RenderViewReady(RenderViewHost* rvh) {

void WebContentsImpl::RenderViewTerminated(RenderViewHost* rvh,

base::TerminationStatus status,

int error_code) {

+ // TODO(nasko): This isn't ideal; the termination process should be handled by

+ // RenderFrameDeleted(). See http://crbug.com/455943

Charlie Reis 2015/02/06 00:08:21 nit: End with period. (Code search gets the link

DaleCurtis 2015/02/06 00:10:31 Done.

+ ClearPowerSaveBlockers(rvh->GetMainFrame());

if (rvh != GetRenderViewHost()) {

// The pending page's RenderViewHost is gone.

return;

« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_impl_unittest.cc » ('j') | content/browser/web_contents/web_contents_impl_unittest.cc » ('J')