Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 886593005: Enhance audio player tests. (Closed)

Created:
5 years, 10 months ago by rkc
Modified:
5 years, 10 months ago
Reviewers:
Charlie
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enhance audio player tests. Enhance the audio player tests to cover multiple loops over the data and odd sizes of data. R=ckehoe@chromium.org BUG=None. Committed: https://crrev.com/0d96f15bd2fc617732fd3465753d498da0eae99f Cr-Commit-Position: refs/heads/master@{#313752}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M components/copresence/mediums/audio/audio_player_unittest.cc View 1 2 3 chunks +24 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
rkc
5 years, 10 months ago (2015-01-29 17:14:09 UTC) #1
Charlie
Thanks for helping debug this! https://codereview.chromium.org/886593005/diff/1/components/copresence/mediums/audio/audio_player_unittest.cc File components/copresence/mediums/audio/audio_player_unittest.cc (right): https://codereview.chromium.org/886593005/diff/1/components/copresence/mediums/audio/audio_player_unittest.cc#newcode185 components/copresence/mediums/audio/audio_player_unittest.cc:185: // Ensure that kNumsamples ...
5 years, 10 months ago (2015-01-29 17:35:03 UTC) #2
rkc
https://codereview.chromium.org/886593005/diff/1/components/copresence/mediums/audio/audio_player_unittest.cc File components/copresence/mediums/audio/audio_player_unittest.cc (right): https://codereview.chromium.org/886593005/diff/1/components/copresence/mediums/audio/audio_player_unittest.cc#newcode185 components/copresence/mediums/audio/audio_player_unittest.cc:185: // Ensure that kNumsamples is never over kMaxFrameCount. On ...
5 years, 10 months ago (2015-01-29 17:42:42 UTC) #3
Charlie
lgtm
5 years, 10 months ago (2015-01-29 18:40:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886593005/40001
5 years, 10 months ago (2015-01-29 18:40:54 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-29 19:16:40 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 19:17:33 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0d96f15bd2fc617732fd3465753d498da0eae99f
Cr-Commit-Position: refs/heads/master@{#313752}

Powered by Google App Engine
This is Rietveld 408576698