Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 886593004: Reland "Don't refcount tracking id -> slot id mapping." (Closed)

Created:
5 years, 10 months ago by tdresser
Modified:
5 years, 10 months ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, tfarina, jdduke+watch_chromium.org, ozone-reviews_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Don't refcount tracking id -> slot id mapping." Previously we tried to refcount the tracking id to slot id mapping. This broke in some circumstances where the number of press events was not equal to the number of release events. This patch switches to marking some touch events such that they don't modify the mapping, simplifying logic, and fixing a nasty bug. Initially landed here: https://codereview.chromium.org/785753002/ Reverted here: https://codereview.chromium.org/869433007/ due to memory failures. BUG=439051 TEST=EventsXTest.TouchEventNotRemovingFromNativeMapping Committed: https://crrev.com/211211ea4a842a8fa27660a915ae23970ef0c63c Cr-Commit-Position: refs/heads/master@{#314327}

Patch Set 1 : Original Patch #

Patch Set 2 : Fix terrible merge. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -99 lines) Patch
M ui/events/cocoa/events_mac.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/events/devices/x11/touch_factory_x11.h View 2 chunks +0 lines, -8 lines 0 comments Download
M ui/events/devices/x11/touch_factory_x11.cc View 2 chunks +1 line, -8 lines 0 comments Download
M ui/events/event.h View 1 6 chunks +16 lines, -6 lines 0 comments Download
M ui/events/event.cc View 1 4 chunks +18 lines, -16 lines 0 comments Download
M ui/events/event_utils.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/events/events_stub.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/events/ozone/events_ozone.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/events/win/events_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/events/x/events_x.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M ui/events/x/events_x_unittest.cc View 1 chunk +22 lines, -29 lines 0 comments Download
M ui/views/controls/menu/menu_controller_unittest.cc View 3 chunks +69 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_event_dispatcher_linux.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tdresser
I've fixed the uninitialized memory issue. I must have been asleep while performing a manual ...
5 years, 10 months ago (2015-01-29 20:33:36 UTC) #2
jdduke (slow)
On 2015/01/29 20:33:36, tdresser wrote: > I've fixed the uninitialized memory issue. I must have ...
5 years, 10 months ago (2015-02-03 00:26:04 UTC) #3
sadrul
lgtm
5 years, 10 months ago (2015-02-03 01:14:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886593004/20001
5 years, 10 months ago (2015-02-03 13:48:50 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 13:52:04 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 13:53:08 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/211211ea4a842a8fa27660a915ae23970ef0c63c
Cr-Commit-Position: refs/heads/master@{#314327}

Powered by Google App Engine
This is Rietveld 408576698