Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 886583005: [Cronet] rename upload_test_server.cc/h (Closed)

Created:
5 years, 10 months ago by xunjieli
Modified:
5 years, 10 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] rename upload_test_server.cc/h BUG=452643 Committed: https://crrev.com/a463dd08ffb612154403fffebf942584fa16f23d Cr-Commit-Position: refs/heads/master@{#314635}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -174 lines) Patch
M components/cronet.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M components/cronet/android/test/cronet_test_jni.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/cronet/android/test/native_test_server.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/cronet/android/test/native_test_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/test/upload_test_server.h View 1 chunk +0 lines, -16 lines 0 comments Download
D components/cronet/android/test/upload_test_server.cc View 1 chunk +0 lines, -151 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
xunjieli
5 years, 10 months ago (2015-02-03 22:38:21 UTC) #4
mef
lgtm, I've missed that first CL only renamed java part. Thanks for doing this.
5 years, 10 months ago (2015-02-04 20:28:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886583005/40001
5 years, 10 months ago (2015-02-04 20:31:09 UTC) #7
xunjieli
On 2015/02/04 20:28:29, mef wrote: > lgtm, I've missed that first CL only renamed java ...
5 years, 10 months ago (2015-02-04 20:31:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 10 months ago (2015-02-04 21:17:50 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 21:18:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a463dd08ffb612154403fffebf942584fa16f23d
Cr-Commit-Position: refs/heads/master@{#314635}

Powered by Google App Engine
This is Rietveld 408576698