Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 886563005: Remove touch-scrolling-mode flag (Closed)

Created:
5 years, 10 months ago by lanwei
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jdduke+watch_chromium.org, jam, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove touch-scrolling-mode flag Because now we are using throttled async touch model for scroll only, we will remove touch-scrolling-mode related code. BUG=350430 Committed: https://crrev.com/220483d0c533c2fa938fd5b150ab03ff77b195a7 Cr-Commit-Position: refs/heads/master@{#314456}

Patch Set 1 : #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -331 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 2 chunks +0 lines, -20 lines 0 comments Download
M content/browser/renderer_host/input/input_router_config_helper.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M content/browser/renderer_host/input/touch_action_browsertest.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.h View 1 2 3 chunks +1 line, -29 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.cc View 1 2 5 chunks +9 lines, -47 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue_unittest.cc View 1 2 12 chunks +5 lines, -187 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
lanwei
5 years, 10 months ago (2015-01-29 23:59:04 UTC) #5
jdduke (slow)
Yay! lgtm. https://codereview.chromium.org/886563005/diff/80001/content/browser/renderer_host/input/touch_event_queue.cc File content/browser/renderer_host/input/touch_event_queue.cc (right): https://codereview.chromium.org/886563005/diff/80001/content/browser/renderer_host/input/touch_event_queue.cc#newcode543 content/browser/renderer_host/input/touch_event_queue.cc:543: if (gesture_event.event.type != blink::WebInputEvent::GestureScrollUpdate) I guess we ...
5 years, 10 months ago (2015-01-30 00:12:56 UTC) #6
Alexei Svitkine (slow)
https://codereview.chromium.org/886563005/diff/80001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/886563005/diff/80001/tools/metrics/histograms/histograms.xml#oldcode50609 tools/metrics/histograms/histograms.xml:50609: - <int value="-1619757314" label="touch-scrolling-mode"/> Entries shouldn't be removed from ...
5 years, 10 months ago (2015-01-30 15:17:28 UTC) #8
lanwei
avi@chromium.org: Please review changes in Can you please look at all these files? Thank you. ...
5 years, 10 months ago (2015-02-03 20:44:32 UTC) #10
tdresser
On 2015/02/03 20:44:32, lanwei wrote: > mailto:avi@chromium.org: Please review changes in > > Can you ...
5 years, 10 months ago (2015-02-03 21:01:28 UTC) #11
Alexei Svitkine (slow)
lgtm
5 years, 10 months ago (2015-02-03 21:13:53 UTC) #12
Avi (use Gerrit)
lgtm kill kill kill kill
5 years, 10 months ago (2015-02-03 21:45:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886563005/100001
5 years, 10 months ago (2015-02-04 01:04:03 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:100001)
5 years, 10 months ago (2015-02-04 01:09:19 UTC) #16
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 01:10:35 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/220483d0c533c2fa938fd5b150ab03ff77b195a7
Cr-Commit-Position: refs/heads/master@{#314456}

Powered by Google App Engine
This is Rietveld 408576698