Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: tools/cygprofile/symbol_extractor_unittest.py

Issue 886563002: Switch from nm to objdump for the cygprofile tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/cygprofile/symbol_extractor_unittest.py
diff --git a/tools/cygprofile/symbol_extractor_unittest.py b/tools/cygprofile/symbol_extractor_unittest.py
index 5b23dfcae345796879af939f22c2ee78d39c09d4..46cc21fd9bc7e30f99196fd28991990fa6fee887 100755
--- a/tools/cygprofile/symbol_extractor_unittest.py
+++ b/tools/cygprofile/symbol_extractor_unittest.py
@@ -8,70 +8,69 @@ import unittest
class TestSymbolInfo(unittest.TestCase):
def testIgnoresBlankLine(self):
- symbol_info = symbol_extractor.FromNmLine('')
+ symbol_info = symbol_extractor._FromObjdumpLine('')
self.assertIsNone(symbol_info)
def testIgnoresMalformedLine(self):
- line = ('00210d59 00000002 t _ZN34BrowserPluginHostMsg_Attach_ParamsD2Ev '
- 'too many fields')
- symbol_info = symbol_extractor.FromNmLine(line)
+ # Too short
+ line = ('00c1b228 F .text 00000060 _ZN20trace_event')
+ symbol_info = symbol_extractor._FromObjdumpLine(line)
self.assertIsNone(symbol_info)
# Wrong marker
- line = '00210d59 00000002 A _ZN34BrowserPluginHostMsg_Attach_ParamsD2Ev'
- symbol_info = symbol_extractor.FromNmLine(line)
- self.assertIsNone(symbol_info)
- # Too short
- line = '00210d59 t'
- symbol_info = symbol_extractor.FromNmLine(line)
+ line = '00c1b228 l f .text 00000060 _ZN20trace_event'
+ symbol_info = symbol_extractor._FromObjdumpLine(line)
self.assertIsNone(symbol_info)
- def testSymbolInfoWithSize(self):
- line = '00210d59 00000002 t _ZN34BrowserPluginHostMsg_Attach_ParamsD2Ev'
- test_name = '_ZN34BrowserPluginHostMsg_Attach_ParamsD2Ev'
- test_offset = 0x210d59
- test_size = 2
- symbol_info = symbol_extractor.FromNmLine(line)
+ def testSymbolInfo(self):
+ line = ('00c1c05c l F .text 0000002c '
+ '_GLOBAL__sub_I_chrome_main_delegate.cc')
+ test_name = '_GLOBAL__sub_I_chrome_main_delegate.cc'
+ test_offset = 0x00c1c05c
+ test_size = 0x2c
+ test_section = '.text'
+ symbol_info = symbol_extractor._FromObjdumpLine(line)
self.assertIsNotNone(symbol_info)
self.assertEquals(test_offset, symbol_info.offset)
self.assertEquals(test_size, symbol_info.size)
self.assertEquals(test_name, symbol_info.name)
+ self.assertEquals(test_section, symbol_info.section)
- def testSymbolInfoWithoutSize(self):
- line = '0070ee8c T WebRtcSpl_ComplexBitReverse'
- test_name = 'WebRtcSpl_ComplexBitReverse'
- test_offset = 0x70ee8c
- symbol_info = symbol_extractor.FromNmLine(line)
+ def testHiddenSymbol(self):
+ line = ('00c1c05c l F .text 0000002c '
+ 'hidden _GLOBAL__sub_I_chrome_main_delegate.cc')
+ test_name = '_GLOBAL__sub_I_chrome_main_delegate.cc'
+ test_offset = 0x00c1c05c
+ test_size = 0x2c
+ test_section = '.text'
+ symbol_info = symbol_extractor._FromObjdumpLine(line)
self.assertIsNotNone(symbol_info)
self.assertEquals(test_offset, symbol_info.offset)
- self.assertEquals(-1, symbol_info.size)
+ self.assertEquals(test_size, symbol_info.size)
self.assertEquals(test_name, symbol_info.name)
-
+ self.assertEquals(test_section, symbol_info.section)
class TestSymbolInfosFromStream(unittest.TestCase):
def testSymbolInfosFromStream(self):
lines = ['Garbage',
'',
- ('00210d59 00000002 t _ZN34BrowserPluginHostMsg_Attach_ParamsD2Ev '
- 'too many fields'),
- '00210d59 00000002 t _ZN34BrowserPluginHostMsg_Attach_ParamsD2Ev',
- '00210d59 00000002 A _ZN34BrowserPluginHostMsg_Attach_ParamsD2Ev',
- '0070ee8c T WebRtcSpl_ComplexBitReverse']
- symbol_infos = symbol_extractor.SymbolInfosFromStream(lines)
+ '00c1c05c l F .text 0000002c first',
+ ''
+ 'more garbage',
+ '00155 g F .text 00000012 second']
+ symbol_infos = symbol_extractor._SymbolInfosFromStream(lines)
self.assertEquals(len(symbol_infos), 2)
- first = symbol_extractor.SymbolInfo(
- '_ZN34BrowserPluginHostMsg_Attach_ParamsD2Ev', 0x00210d59, 2)
+ first = symbol_extractor.SymbolInfo('first', 0x00c1c05c, 0x2c, '.text')
self.assertEquals(first, symbol_infos[0])
- second = symbol_extractor.SymbolInfo(
- 'WebRtcSpl_ComplexBitReverse', 0x0070ee8c, -1)
+ second = symbol_extractor.SymbolInfo('second', 0x00155, 0x12, '.text')
self.assertEquals(second, symbol_infos[1])
class TestSymbolInfoMappings(unittest.TestCase):
def setUp(self):
self.symbol_infos = [
- symbol_extractor.SymbolInfo('firstNameAtOffset', 0x42, 42),
- symbol_extractor.SymbolInfo('secondNameAtOffset', 0x42, 42),
- symbol_extractor.SymbolInfo('thirdSymbol', 0x64, 20)]
+ symbol_extractor.SymbolInfo('firstNameAtOffset', 0x42, 42, '.text'),
+ symbol_extractor.SymbolInfo('secondNameAtOffset', 0x42, 42, '.text'),
+ symbol_extractor.SymbolInfo('thirdSymbol', 0x64, 20, '.text')]
def testGroupSymbolInfosByOffset(self):
offset_to_symbol_info = symbol_extractor.GroupSymbolInfosByOffset(
« tools/cygprofile/symbol_extractor.py ('K') | « tools/cygprofile/symbol_extractor.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698