tools/cygprofile/patch_orderfile.py - Issue 886563002: Switch from nm to objdump for the cygprofile tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/cygprofile/patch_orderfile.py

Issue 886563002: Switch from nm to objdump for the cygprofile tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/cygprofile/patch_orderfile.py

diff --git a/tools/cygprofile/patch_orderfile.py b/tools/cygprofile/patch_orderfile.py

index 0b3cdb6b38bb9f0994cfda565e450575b353b5e4..d898b99e15ccf8e35365069ea485290b660b0b1a 100755

--- a/tools/cygprofile/patch_orderfile.py

+++ b/tools/cygprofile/patch_orderfile.py

@@ -58,7 +58,8 @@ def _GroupSymbolInfos(symbol_infos):

for symbol in symbol_infos:

symbol = symbol_extractor.SymbolInfo(name=_RemoveClone(symbol.name),

offset=symbol.offset,

- size=symbol.size)

+ size=symbol.size,

+ section=symbol.section)

offset_to_symbol_infos[symbol.offset].append(symbol)

name_to_symbol_infos[symbol.name].append(symbol)

return (dict(offset_to_symbol_infos), dict(name_to_symbol_infos))