Switch from nm to objdump for the cygprofile tools.

tools/cygprofile/symbol_extractor_unittest.py

+#!/usr/bin/python
+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import symbol_extractor
+import unittest
+
+class TestSymbolInfo(unittest.TestCase):
+  def testIgnoresBlankLine(self):
+    symbol_info = symbol_extractor._FromObjdumpLine('')
+    self.assertIsNone(symbol_info)
+
+  def testIgnoresMalformedLine(self):
+    # Too short

[pasko, 2015/01/29 12:24:43]

All our styleguides strongly recommend the comments that occupy their lines
would contain a sequence of _sentences_. Sentences must start from a capital
letter and end with a period.

This one should say something like:
# The following line is too short for the parser.

or just:
# This line is too short.

[Benoit L, 2015/01/29 13:10:30]

Done.

+    line = ('00c1b228      F .text  00000060 _ZN20trace_event')
+    symbol_info = symbol_extractor._FromObjdumpLine(line)
+    self.assertIsNone(symbol_info)
+    # Wrong marker
+    line = '00c1b228 l     f .text  00000060 _ZN20trace_event'
+    symbol_info = symbol_extractor._FromObjdumpLine(line)
+    self.assertIsNone(symbol_info)
+
+  def testSymbolInfo(self):
+    line = ('00c1c05c l     F .text  0000002c '
+            '_GLOBAL__sub_I_chrome_main_delegate.cc')
+    test_name = '_GLOBAL__sub_I_chrome_main_delegate.cc'
+    test_offset = 0x00c1c05c
+    test_size = 0x2c
+    test_section = '.text'
+    symbol_info = symbol_extractor._FromObjdumpLine(line)
+    self.assertIsNotNone(symbol_info)
+    self.assertEquals(test_offset, symbol_info.offset)
+    self.assertEquals(test_size, symbol_info.size)
+    self.assertEquals(test_name, symbol_info.name)
+    self.assertEquals(test_section, symbol_info.section)
+
+  def testHiddenSymbol(self):
+    line = ('00c1c05c l     F .text  0000002c '
+            'hidden _GLOBAL__sub_I_chrome_main_delegate.cc')

[pasko, 2015/01/29 12:24:42]

s/hidden/.hidden/

I <3 realism.

[Benoit L, 2015/01/29 13:10:30]

Done.

+    test_name = '_GLOBAL__sub_I_chrome_main_delegate.cc'
+    test_offset = 0x00c1c05c
+    test_size = 0x2c
+    test_section = '.text'
+    symbol_info = symbol_extractor._FromObjdumpLine(line)
+    self.assertIsNotNone(symbol_info)
+    self.assertEquals(test_offset, symbol_info.offset)
+    self.assertEquals(test_size, symbol_info.size)
+    self.assertEquals(test_name, symbol_info.name)
+    self.assertEquals(test_section, symbol_info.section)
+
+class TestSymbolInfosFromStream(unittest.TestCase):

[pasko, 2015/01/29 12:24:42]

more whitespace is absolutely necessary, otherwise human parsers become even
less reliable. I am wondering why pyling does not complain about these :)

[Benoit L, 2015/01/29 13:10:30]

Done.

+  def testSymbolInfosFromStream(self):
+    lines = ['Garbage',
+             '',
+             '00c1c05c l     F .text  0000002c first',
+             ''
+             'more garbage',
+             '00155 g     F .text  00000012 second']
+    symbol_infos = symbol_extractor._SymbolInfosFromStream(lines)
+    self.assertEquals(len(symbol_infos), 2)
+    first = symbol_extractor.SymbolInfo('first', 0x00c1c05c, 0x2c, '.text')
+    self.assertEquals(first, symbol_infos[0])
+    second = symbol_extractor.SymbolInfo('second', 0x00155, 0x12, '.text')
+    self.assertEquals(second, symbol_infos[1])
+
+
+class TestSymbolInfoMappings(unittest.TestCase):
+  def setUp(self):
+    self.symbol_infos = [
+        symbol_extractor.SymbolInfo('firstNameAtOffset', 0x42, 42, '.text'),
+        symbol_extractor.SymbolInfo('secondNameAtOffset', 0x42, 42, '.text'),
+        symbol_extractor.SymbolInfo('thirdSymbol', 0x64, 20, '.text')]
+
+  def testGroupSymbolInfosByOffset(self):
+    offset_to_symbol_info = symbol_extractor.GroupSymbolInfosByOffset(
+        self.symbol_infos)
+    self.assertEquals(len(offset_to_symbol_info), 2)
+    self.assertIn(0x42, offset_to_symbol_info)
+    self.assertEquals(offset_to_symbol_info[0x42][0], self.symbol_infos[0])
+    self.assertEquals(offset_to_symbol_info[0x42][1], self.symbol_infos[1])
+    self.assertIn(0x64, offset_to_symbol_info)
+    self.assertEquals(offset_to_symbol_info[0x64][0], self.symbol_infos[2])
+
+  def testCreateNameToSymbolInfos(self):

[pasko, 2015/01/29 12:24:43]

nittish nit:

if this test is to stay, probably should be named testCreateNameToSymbolInfo
(without the trailing 's'), to suggest what function it is testing, and less to
suggest what it's doing.

[Benoit L, 2015/01/29 13:10:30]

Done.

+    name_to_symbol_info = symbol_extractor.CreateNameToSymbolInfo(
+        self.symbol_infos)
+    self.assertEquals(len(name_to_symbol_info), 3)
+    for i in range(3):
+      name = self.symbol_infos[i].name
+      self.assertIn(name, name_to_symbol_info)
+      self.assertEquals(self.symbol_infos[i], name_to_symbol_info[name])
+
+
+
+if __name__ == '__main__':
+  unittest.main()