[Chromoting] Set ar_service_environment for Official builds

[Chromoting] Set ar_service_environment for Official builds

There is a check in build-webapp.py (line 197) that ensures that
non-dev builds have this set to 'prod'. Up 'til now, we've been
setting this manually (hence the check in build-webapp), but it
is better to set it correctly in the gyp file.

This also allows the bots to build Official builds without
triggering the build-webapp check.

BUG=

Committed: https://crrev.com/cc72a99023c77d7efa98fd24cd8d16795fead2a4
Cr-Commit-Position: refs/heads/master@{#313558}

[garykac, 2015-01-28 16:48:22]

garykac@chromium.org changed reviewers:
+ weitaosu@chromium.org

[garykac, 2015-01-28 16:48:23]

https://codereview.chromium.org/886543002/diff/1/remoting/app_remoting_webapp...
File remoting/app_remoting_webapp_build.gypi (right):

https://codereview.chromium.org/886543002/diff/1/remoting/app_remoting_webapp...
remoting/app_remoting_webapp_build.gypi:20: 'ar_service_environment%': 'dev',
FYI: original def for ar_service_environment

[weitao, 2015-01-28 17:47:25]

https://codereview.chromium.org/886543002/diff/1/remoting/app_remoting_webapp...
File remoting/app_remoting_webapp_build.gypi (right):

https://codereview.chromium.org/886543002/diff/1/remoting/app_remoting_webapp...
remoting/app_remoting_webapp_build.gypi:20: 'ar_service_environment%': 'dev',
Can conditions be embedded in the variables section? If so I think it is more
clear initialize ar_service_environment to the correct value here.

[garykac, 2015-01-28 18:25:55]

ptal

https://codereview.chromium.org/886543002/diff/1/remoting/app_remoting_webapp...
File remoting/app_remoting_webapp_build.gypi (right):

https://codereview.chromium.org/886543002/diff/1/remoting/app_remoting_webapp...
remoting/app_remoting_webapp_build.gypi:20: 'ar_service_environment%': 'dev',
On 2015/01/28 17:47:25, weitaosu wrote:
> Can conditions be embedded in the variables section? If so I think it is more
> clear initialize ar_service_environment to the correct value here.

Done.

[weitao, 2015-01-28 18:31:16]

LGTM

[garykac, 2015-01-28 18:48:01]

The CQ bit was checked by garykac@chromium.org

[commit-bot: I haz the power, 2015-01-28 18:48:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/886543002/20001

[commit-bot: I haz the power, 2015-01-28 19:12:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-28 19:13:00]

Patchset 2 (id:??) landed as
https://crrev.com/cc72a99023c77d7efa98fd24cd8d16795fead2a4
Cr-Commit-Position: refs/heads/master@{#313558}