Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 88653003: Add literal handling to experimental scanner. (Closed)

Created:
7 years ago by ulan
Modified:
7 years ago
Reviewers:
marja
CC:
v8-dev
Visibility:
Public.

Description

Add literal handling to experimental scanner. Replace the baseline scanner with the experimental scanner in compilation pipeline. Based on https://codereview.chromium.org/87783004/ TBR=marja@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18100

Patch Set 1 #

Patch Set 2 : Scan escapes #

Patch Set 3 : Compile errors #

Patch Set 4 : FillLiteral for UTF16 #

Patch Set 5 : Now compiles #

Patch Set 6 : #

Patch Set 7 : Fix errors #

Patch Set 8 : Fix printing #

Patch Set 9 : Landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+635 lines, -306 lines) Patch
M src/lexer/experimental-scanner.h View 1 2 3 4 5 6 14 chunks +221 lines, -22 lines 0 comments Download
M src/lexer/experimental-scanner.cc View 1 2 3 4 5 6 7 8 1 chunk +95 lines, -0 lines 0 comments Download
M src/lexer/lexer-shell.cc View 1 2 3 4 5 6 7 3 chunks +53 lines, -10 lines 0 comments Download
M src/parser.h View 1 2 3 4 5 6 6 chunks +8 lines, -7 lines 0 comments Download
M src/parser.cc View 1 2 3 4 5 6 7 8 18 chunks +52 lines, -70 lines 0 comments Download
M src/preparser.h View 8 chunks +13 lines, -12 lines 0 comments Download
M src/preparser.cc View 18 chunks +21 lines, -21 lines 0 comments Download
M src/runtime.js View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 3 4 5 6 7 8 4 chunks +168 lines, -164 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ulan
7 years ago (2013-11-27 13:01:48 UTC) #1
Message was sent while issue was closed.
Committed patchset #9 manually as r18100 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698