Move GetVisibleNetworks network type filtering to WiFiService interface.

Move GetVisibleNetworks network type filtering to WiFiService interface. 

Fix incorrect naming process_client => service_client, service_path => network_guid.

BUG=267667
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237460

[mef, 2013-11-26 16:21:37]

Hi guys,

please take a look:

Toni - overall.
Steven - chrome/browser/extensions/api/networking_private/*.
Chris - FYI, move GetVisibleNetworks network type filtering to WiFiService
interface (adopted from https://codereview.chromium.org/30753002/).

thanks,
-m

[stevenjb, 2013-11-26 17:35:55]

https://codereview.chromium.org/88653002/diff/1/components/wifi/wifi_service_...
File components/wifi/wifi_service_win.cc (right):

https://codereview.chromium.org/88653002/diff/1/components/wifi/wifi_service_...
components/wifi/wifi_service_win.cc:433: network_type ==
onc::network_type::kWiFi);
network_type comes more-or-less directly from the JS, right? Unless we logically
ensure this condition somewhere, this should fail gracefully (i.e. WARNING +
early exit instead of CHECK).

[stevenjb, 2013-11-26 17:36:49]

Thanks for separating this btw. lgtm with the DCHECK removed (or comment with
where the condition is ensured).

[mef, 2013-11-26 18:30:39]

Steven, thanks!

https://codereview.chromium.org/88653002/diff/1/components/wifi/wifi_service_...
File components/wifi/wifi_service_win.cc (right):

https://codereview.chromium.org/88653002/diff/1/components/wifi/wifi_service_...
components/wifi/wifi_service_win.cc:433: network_type ==
onc::network_type::kWiFi);
On 2013/11/26 17:35:55, stevenjb wrote:
> network_type comes more-or-less directly from the JS, right? Unless we
logically
> ensure this condition somewhere, this should fail gracefully (i.e. WARNING +
> early exit instead of CHECK).

Done.

[tbarzic, 2013-11-26 18:39:36]

lgtm

https://codereview.chromium.org/88653002/diff/1/components/wifi/fake_wifi_ser...
File components/wifi/fake_wifi_service.cc (right):

https://codereview.chromium.org/88653002/diff/1/components/wifi/fake_wifi_ser...
components/wifi/fake_wifi_service.cc:117: network_type == it->type) {
nit: I find it more natural to have the value that you're testing (it->type) on
the left and the value you test against (network_type) on the right of ==
(but, feel free to ignore this)

https://codereview.chromium.org/88653002/diff/20001/components/wifi/wifi_serv...
File components/wifi/wifi_service_win.cc (right):

https://codereview.chromium.org/88653002/diff/20001/components/wifi/wifi_serv...
components/wifi/wifi_service_win.cc:432: network_type ==
onc::network_type::kAllTypes ||
nit: I think that if (!a && !b && !c) looks nicer than if (!(a || b || c))

[mef, 2013-11-26 18:59:15]

Toni, thanks!

https://codereview.chromium.org/88653002/diff/1/components/wifi/fake_wifi_ser...
File components/wifi/fake_wifi_service.cc (right):

https://codereview.chromium.org/88653002/diff/1/components/wifi/fake_wifi_ser...
components/wifi/fake_wifi_service.cc:117: network_type == it->type) {
On 2013/11/26 18:39:36, tbarzic wrote:
> nit: I find it more natural to have the value that you're testing (it->type)
on
> the left and the value you test against (network_type) on the right of ==
> (but, feel free to ignore this)

Done.

https://codereview.chromium.org/88653002/diff/20001/components/wifi/wifi_serv...
File components/wifi/wifi_service_win.cc (right):

https://codereview.chromium.org/88653002/diff/20001/components/wifi/wifi_serv...
components/wifi/wifi_service_win.cc:432: network_type ==
onc::network_type::kAllTypes ||
On 2013/11/26 18:39:36, tbarzic wrote:
> nit: I think that if (!a && !b && !c) looks nicer than if (!(a || b || c))

Done.

[commit-bot: I haz the power, 2013-11-26 19:50:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mef@chromium.org/88653002/40001

[commit-bot: I haz the power, 2013-11-27 01:06:50]

Change committed as 237460