Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1163)

Unified Diff: chrome/browser/metrics/metrics_services_manager_unittest.cc

Issue 886523003: Add a Rappor option in the settings page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_services_manager_unittest.cc
diff --git a/chrome/browser/metrics/metrics_services_manager_unittest.cc b/chrome/browser/metrics/metrics_services_manager_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..80940f380f9de6ba0ad436626c664e0017373a4b
--- /dev/null
+++ b/chrome/browser/metrics/metrics_services_manager_unittest.cc
@@ -0,0 +1,122 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/metrics/metrics_services_manager.h"
+
+#include <string>
+
+#include "base/prefs/testing_pref_service.h"
+#include "chrome/common/pref_names.h"
+#include "chrome/test/base/testing_browser_process.h"
+#include "chrome/test/base/testing_profile_manager.h"
+#include "components/rappor/rappor_pref_names.h"
+#include "components/rappor/rappor_prefs.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+class MetricsServicesManagerTest : public testing::Test {
+ public:
+ MetricsServicesManagerTest()
+ : test_profile_manager_(TestingBrowserProcess::GetGlobal()),
+ manager_(&test_prefs_) {
+ rappor::internal::RegisterPrefs(test_prefs_.registry());
+ }
+
+ void SetUp() override {
+ ASSERT_TRUE(test_profile_manager_.SetUp());
+ }
+
+ void CreateProfile(const std::string& name, bool sb_enabled) {
+ TestingProfile* profile = test_profile_manager_.CreateTestingProfile(name);
+ profile->GetPrefs()->SetBoolean(prefs::kSafeBrowsingEnabled, sb_enabled);
+ }
+
+ TestingPrefServiceSimple* test_prefs() { return &test_prefs_; }
+
+ MetricsServicesManager* manager() { return &manager_; }
+
+ private:
+ TestingProfileManager test_profile_manager_;
+ TestingPrefServiceSimple test_prefs_;
+ MetricsServicesManager manager_;
+
+ DISALLOW_COPY_AND_ASSIGN(MetricsServicesManagerTest);
+};
+
+TEST_F(MetricsServicesManagerTest, CheckRapporDefaultDisable) {
+ test_prefs()->ClearPref(rappor::prefs::kRapporEnabled);
+ CreateProfile("profile1", true);
+ CreateProfile("profile2", false);
+ bool uma_enabled = false;
+
+ EXPECT_FALSE(manager()->IsRapporEnabled(uma_enabled));
+ EXPECT_TRUE(test_prefs()->HasPrefPath(rappor::prefs::kRapporEnabled));
Alexei Svitkine (slow) 2015/02/09 20:42:13 Nit: Also check the pref value - for all of these.
Steven Holte 2015/02/09 21:09:23 Done.
+}
+
+TEST_F(MetricsServicesManagerTest, CheckRapporDefaultEnabledBySafeBrowsing) {
+ test_prefs()->ClearPref(rappor::prefs::kRapporEnabled);
+ CreateProfile("profile1", true);
+ CreateProfile("profile2", true);
+ bool uma_enabled = false;
+
+ EXPECT_TRUE(manager()->IsRapporEnabled(uma_enabled));
+ EXPECT_TRUE(test_prefs()->HasPrefPath(rappor::prefs::kRapporEnabled));
+}
+
+TEST_F(MetricsServicesManagerTest, CheckRapporDefaultEnabledByUMA) {
+ test_prefs()->ClearPref(rappor::prefs::kRapporEnabled);
+ CreateProfile("profile1", false);
+ CreateProfile("profile2", false);
+ bool uma_enabled = true;
+
+ EXPECT_TRUE(manager()->IsRapporEnabled(uma_enabled));
+ EXPECT_TRUE(test_prefs()->HasPrefPath(rappor::prefs::kRapporEnabled));
+}
+
+TEST_F(MetricsServicesManagerTest, CheckRapporEnable) {
+ test_prefs()->SetBoolean(rappor::prefs::kRapporEnabled, true);
+ CreateProfile("profile1", false);
+ CreateProfile("profile2", false);
+ bool uma_enabled = false;
+
+ EXPECT_TRUE(manager()->IsRapporEnabled(uma_enabled));
+}
+
+TEST_F(MetricsServicesManagerTest, CheckRapporDisable) {
+ test_prefs()->SetBoolean(rappor::prefs::kRapporEnabled, false);
+ CreateProfile("profile1", true);
+ CreateProfile("profile2", true);
+ bool uma_enabled = true;
+
+ EXPECT_FALSE(manager()->IsRapporEnabled(uma_enabled));
+}
+
+#if defined(GOOGLE_CHROME_BUILD)
+#if !defined(OS_IOS) && !defined(OS_ANDROID)
+
+TEST_F(MetricsServicesManagerTest, GetRecordingLevelDisabled) {
+ test_prefs()->SetBoolean(rappor::prefs::kRapporEnabled, false);
+ bool uma_enabled = true;
+
+ EXPECT_EQ(rappor::RECORDING_DISABLED,
+ manager()->GetRapporRecordingLevel(uma_enabled));
+}
+
+TEST_F(MetricsServicesManagerTest, GetRecordingLevelFine) {
+ test_prefs()->SetBoolean(rappor::prefs::kRapporEnabled, true);
+ bool uma_enabled = true;
+
+ EXPECT_EQ(rappor::FINE_LEVEL,
+ manager()->GetRapporRecordingLevel(uma_enabled));
+}
+
+TEST_F(MetricsServicesManagerTest, GetRecordingLevelCoarse) {
+ test_prefs()->SetBoolean(rappor::prefs::kRapporEnabled, true);
+ bool uma_enabled = false;
+
+ EXPECT_EQ(rappor::COARSE_LEVEL,
+ manager()->GetRapporRecordingLevel(uma_enabled));
+}
+
+#endif // !defined(OS_IOS) && !defined(OS_ANDROID)
+#endif // defined(GOOGLE_CHROME_BUILD)

Powered by Google App Engine
This is Rietveld 408576698