Add a Rappor option in the settings page.

chrome/browser/metrics/metrics_services_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/metrics_services_manager.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/metrics/chrome_metrics_service_client.h"
 #include "chrome/browser/metrics/variations/variations_service.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/browser_otr_state.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/installer/util/google_update_settings.h"
 #include "components/metrics/metrics_service.h"
 #include "components/metrics/metrics_state_manager.h"
+#include "components/rappor/rappor_pref_names.h"
 #include "components/rappor/rappor_service.h"
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #endif
 
+namespace {
+
+// Check if the safe browsing setting is enabled for all existing profiles.
+bool CheckSafeBrowsingSettings() {
+  bool all_enabled = true;
+  ProfileManager* profile_manager = g_browser_process->profile_manager();
+  if (profile_manager) {
+    std::vector<Profile*> profiles = profile_manager->GetLoadedProfiles();
+    for (size_t i = 0; i < profiles.size(); ++i) {
+      if (profiles[i]->IsOffTheRecord())
+        continue;
+      all_enabled = all_enabled && profiles[i]->GetPrefs()->GetBoolean(
+          prefs::kSafeBrowsingEnabled);
+    }
+  }
+  return all_enabled;
+}
+
+}  // namespace
+
 MetricsServicesManager::MetricsServicesManager(PrefService* local_state)
     : local_state_(local_state) {
   DCHECK(local_state);
 }
 
 MetricsServicesManager::~MetricsServicesManager() {
 }
 
 metrics::MetricsService* MetricsServicesManager::GetMetricsService() {
   DCHECK(thread_checker_.CalledOnValidThread());
@@ skipping 42 matching lines @@
     metrics_state_manager_ = metrics::MetricsStateManager::Create(
         local_state_,
         base::Bind(&MetricsServicesManager::IsMetricsReportingEnabled,
                    base::Unretained(this)),
         base::Bind(&GoogleUpdateSettings::StoreMetricsClientInfo),
         base::Bind(&GoogleUpdateSettings::LoadMetricsClientInfo));
   }
   return metrics_state_manager_.get();
 }
 
+bool MetricsServicesManager::IsRapporEnabled(bool metrics_enabled) const {
+  if (!local_state_->HasPrefPath(rappor::prefs::kRapporEnabled)) {

[Alexei Svitkine (slow), 2015/02/06 22:31:11]

Can you add a test for this?

[Steven Holte, 2015/02/07 02:26:21]

Done.

+    // For upgrading users, derive an initial setting from UMA / safe browsing.
+    bool should_enable = metrics_enabled || CheckSafeBrowsingSettings();
+    local_state_->SetBoolean(rappor::prefs::kRapporEnabled, should_enable);
+  }
+  return local_state_->GetBoolean(rappor::prefs::kRapporEnabled);
+}
+
 void MetricsServicesManager::UpdatePermissions(bool may_record,
                                                bool may_upload) {
   metrics::MetricsService* metrics = GetMetricsService();
 
   const base::CommandLine* cmdline = base::CommandLine::ForCurrentProcess();
 
   const bool only_do_metrics_recording =
       cmdline->HasSwitch(switches::kMetricsRecordingOnly) ||
       cmdline->HasSwitch(switches::kEnableBenchmarking);
 
   if (only_do_metrics_recording) {
     metrics->StartRecordingForTests();
     GetRapporService()->Update(rappor::FINE_LEVEL, false);
     return;
   }
 
   if (may_record) {
     if (!metrics->recording_active())
       metrics->Start();
 
     if (may_upload)
       metrics->EnableReporting();
     else
       metrics->DisableReporting();
   } else if (metrics->recording_active() || metrics->reporting_active()) {
     metrics->Stop();
   }
 
-  rappor::RecordingLevel recording_level = may_record ?
-      rappor::FINE_LEVEL : rappor::RECORDING_DISABLED;
+  rappor::RecordingLevel recording_level = rappor::RECORDING_DISABLED;
+#if defined(GOOGLE_CHROME_BUILD)
+#if defined(OS_IOS) || defined(OS_ANDROID)
+  if (may_record) {
+    recording_level = rappor::FINE_LEVEL;
+  }
+#else  // defined(OS_IOS) || defined(OS_ANDROID)

[Alexei Svitkine (slow), 2015/02/06 22:31:11]

Why is there different logic between mobile and desktop?

[Steven Holte, 2015/02/06 22:51:46]

Because they have a different settings UI that I haven't added the option to
turn off RAPPOR to yet.  Once that's in I can remove this.  I'll add a TODO.

+  if (IsRapporEnabled(may_record)) {
+    recording_level = may_record ? rappor::FINE_LEVEL : rappor::COARSE_LEVEL;
+  }
+#endif  // defined(OS_IOS) || defined(OS_ANDROID)
+#endif  // defined(GOOGLE_CHROME_BUILD)
   GetRapporService()->Update(recording_level, may_upload);
 }
 
 // TODO(asvitkine): This function does not report the correct value on Android,
 // see http://crbug.com/362192.
 bool MetricsServicesManager::IsMetricsReportingEnabled() const {
   // If the user permits metrics reporting with the checkbox in the
   // prefs, we turn on recording.  We disable metrics completely for
   // non-official builds, or when field trials are forced.
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kForceFieldTrials))
     return false;
 
   bool enabled = false;
 #if defined(GOOGLE_CHROME_BUILD)
 #if defined(OS_CHROMEOS)
   chromeos::CrosSettings::Get()->GetBoolean(chromeos::kStatsReportingPref,
                                             &enabled);
 #else
   enabled = local_state_->GetBoolean(prefs::kMetricsReportingEnabled);
 #endif  // #if defined(OS_CHROMEOS)
 #endif  // defined(GOOGLE_CHROME_BUILD)
   return enabled;
 }