Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 886503006: Handle sorted event. (Closed)

Created:
5 years, 10 months ago by yawano
Modified:
5 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle sorted event. BUG=438050 TEST=out/Release/browser_tests --gtest_filter=FileManagerJsTest.ListThumbnailLoader Committed: https://crrev.com/a2c2843842191c49a271d88a3a422cc7e1efbccd Cr-Commit-Position: refs/heads/master@{#314990}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -11 lines) Patch
M ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js View 3 chunks +14 lines, -11 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.html View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.js View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yawano
PTAL. Thank you!
5 years, 10 months ago (2015-02-06 06:41:42 UTC) #2
hirono
lgtm!
5 years, 10 months ago (2015-02-06 06:46:16 UTC) #3
yawano
On 2015/02/06 06:46:16, hirono wrote: > lgtm! Thank you!
5 years, 10 months ago (2015-02-06 06:47:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886503006/1
5 years, 10 months ago (2015-02-06 06:47:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 07:08:27 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 07:09:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2c2843842191c49a271d88a3a422cc7e1efbccd
Cr-Commit-Position: refs/heads/master@{#314990}

Powered by Google App Engine
This is Rietveld 408576698