Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 886503002: Extract LoadAccessor into a masm function. (Closed)

Created:
5 years, 10 months ago by ulan
Modified:
5 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Extract LoadAccessor into a masm function. BUG= Committed: https://crrev.com/528401462379a2548e0fb55e04b36961229c6942 Cr-Commit-Position: refs/heads/master@{#26310}

Patch Set 1 #

Patch Set 2 : Fix whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -84 lines) Patch
M src/arm/macro-assembler-arm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL. This removes code duplication in handler for loading getter/setter.
5 years, 10 months ago (2015-01-28 15:49:15 UTC) #2
Igor Sheludko
Very nice! lgtm
5 years, 10 months ago (2015-01-28 15:55:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886503002/20001
5 years, 10 months ago (2015-01-28 16:00:50 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-28 16:31:36 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 16:31:54 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/528401462379a2548e0fb55e04b36961229c6942
Cr-Commit-Position: refs/heads/master@{#26310}

Powered by Google App Engine
This is Rietveld 408576698