sky/engine/core/rendering/RenderLineBoxList.cpp - Issue 886483006: Simplify paint phase boolean logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderLineBoxList.cpp

Issue 886483006: Simplify paint phase boolean logic. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/engine/core/rendering/RenderLineBoxList.cpp

diff --git a/sky/engine/core/rendering/RenderLineBoxList.cpp b/sky/engine/core/rendering/RenderLineBoxList.cpp

index 94167595e13c30185e88629365a555ba78ce44b7..9f92c26b65839a2dd4055f9a6fa38c55ee0de59c 100644

--- a/sky/engine/core/rendering/RenderLineBoxList.cpp

+++ b/sky/engine/core/rendering/RenderLineBoxList.cpp

@@ -187,11 +187,6 @@ bool RenderLineBoxList::lineIntersectsDirtyRect(RenderBoxModelObject* renderer,

void RenderLineBoxList::paint(RenderBoxModelObject* renderer, PaintInfo& paintInfo, const LayoutPoint& paintOffset) const

{

- if (paintInfo.phase != PaintPhaseForeground

- && paintInfo.phase != PaintPhaseSelection

- && paintInfo.phase != PaintPhaseMask)

- return;

ASSERT(renderer->isRenderBlock() || (renderer->isRenderInline() && renderer->hasLayer())); // The only way an inline could paint like this is if it has a layer.

// If we have no lines then we have no work to do.

« no previous file with comments | « sky/engine/core/rendering/RenderBlock.cpp ('k') | sky/engine/core/rendering/RenderReplaced.cpp » ('j') | no next file with comments »