sky/engine/core/rendering/InlineBox.cpp - Issue 886483006: Simplify paint phase boolean logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/InlineBox.cpp

Issue 886483006: Simplify paint phase boolean logic. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/InlineBox.cpp

diff --git a/sky/engine/core/rendering/InlineBox.cpp b/sky/engine/core/rendering/InlineBox.cpp

index 793f7579b1f0f93ffd8bd522509b5f4ed20cafe3..e2ab8dc3e06a6f1c6337f0893a3db5207a60221b 100644

--- a/sky/engine/core/rendering/InlineBox.cpp

+++ b/sky/engine/core/rendering/InlineBox.cpp

@@ -193,7 +193,7 @@ void InlineBox::adjustPosition(float dx, float dy)

void InlineBox::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset, LayoutUnit /* lineTop */, LayoutUnit /*lineBottom*/)

{

- if (paintInfo.phase != PaintPhaseForeground && paintInfo.phase != PaintPhaseSelection)

+ if (paintInfo.phase == PaintPhaseMask)

return;

LayoutPoint childPoint = paintOffset;

« no previous file with comments | « no previous file | sky/engine/core/rendering/RenderBlock.cpp » ('j') | no next file with comments »