Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 886483004: Include a machine id in log files. (Closed)

Created:
5 years, 10 months ago by Steve McKay
Modified:
5 years, 10 months ago
Reviewers:
fukino
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include a machine id in log files. This is the first step in making more reliable cross-machine history synching. A subsequent step will support reading data from the history files from other machines. Also, updated the debug log to employ machine id. BUG=420680 TEST=browser_test: FileManagerJsTest.* Committed: https://crrev.com/232ba71f6a0cab4e2118a261f4909d0d395d52f8 Cr-Commit-Position: refs/heads/master@{#313799}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Merge w/ master. #

Patch Set 3 : Respond to review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -25 lines) Patch
M ui/file_manager/file_manager/background/js/import_history.js View 2 chunks +10 lines, -10 lines 0 comments Download
M ui/file_manager/file_manager/common/js/importer_common.js View 1 2 3 chunks +83 lines, -5 lines 0 comments Download
M ui/file_manager/file_manager/common/js/importer_common_unittest.js View 2 chunks +35 lines, -5 lines 0 comments Download
M ui/file_manager/file_manager/common/js/unittest_util.js View 1 2 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Steve McKay
I think Tomasz is traveling...and missed this review.
5 years, 10 months ago (2015-01-29 19:12:06 UTC) #3
fukino
lgtm with nits. https://codereview.chromium.org/886483004/diff/1/ui/file_manager/file_manager/common/js/importer_common.js File ui/file_manager/file_manager/common/js/importer_common.js (right): https://codereview.chromium.org/886483004/diff/1/ui/file_manager/file_manager/common/js/importer_common.js#newcode138 ui/file_manager/file_manager/common/js/importer_common.js:138: * @type {string} nit: @const https://codereview.chromium.org/886483004/diff/1/ui/file_manager/file_manager/common/js/importer_common.js#newcode166 ...
5 years, 10 months ago (2015-01-29 19:34:53 UTC) #4
Steve McKay
Merge w/ master.
5 years, 10 months ago (2015-01-29 21:14:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886483004/20001
5 years, 10 months ago (2015-01-29 21:15:18 UTC) #7
Steve McKay
Dones. Thanks! https://codereview.chromium.org/886483004/diff/1/ui/file_manager/file_manager/common/js/importer_common.js File ui/file_manager/file_manager/common/js/importer_common.js (right): https://codereview.chromium.org/886483004/diff/1/ui/file_manager/file_manager/common/js/importer_common.js#newcode138 ui/file_manager/file_manager/common/js/importer_common.js:138: * @type {string} On 2015/01/29 19:34:53, fukino ...
5 years, 10 months ago (2015-01-29 21:15:58 UTC) #8
Steve McKay
Respond to review comments.
5 years, 10 months ago (2015-01-29 21:16:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886483004/40001
5 years, 10 months ago (2015-01-29 21:16:42 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-29 21:52:48 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 21:54:27 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/232ba71f6a0cab4e2118a261f4909d0d395d52f8
Cr-Commit-Position: refs/heads/master@{#313799}

Powered by Google App Engine
This is Rietveld 408576698