Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 886473003: add more checks for computing clamp counts, remove dead code (Closed)

Created:
5 years, 10 months ago by reed1
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add more checks for computing clamp counts, remove dead code BUG=448299 Committed: https://skia.googlesource.com/skia/+/9d91eb313623dca16bc988bad2e8b01712e4c578

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : update comment on overflow test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -10 lines) Patch
M src/effects/gradients/SkClampRange.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/effects/gradients/SkClampRange.cpp View 1 2 3 6 chunks +38 lines, -10 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/GradientTest.cpp View 1 2 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
reed1
5 years, 10 months ago (2015-01-28 15:04:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886473003/1
5 years, 10 months ago (2015-01-28 15:05:16 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-01-28 15:05:16 UTC) #5
f(malita)
lgtm https://codereview.chromium.org/886473003/diff/1/src/effects/gradients/SkLinearGradient.cpp File src/effects/gradients/SkLinearGradient.cpp (right): https://codereview.chromium.org/886473003/diff/1/src/effects/gradients/SkLinearGradient.cpp#newcode152 src/effects/gradients/SkLinearGradient.cpp:152: range.validate(count); Nit: if we're always validating after init(), ...
5 years, 10 months ago (2015-01-28 15:43:47 UTC) #8
reed1
now with a fix (until we write a faster one in ASM... https://codereview.chromium.org/886473003/diff/1/src/effects/gradients/SkLinearGradient.cpp File src/effects/gradients/SkLinearGradient.cpp ...
5 years, 10 months ago (2015-01-28 19:04:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886473003/20001
5 years, 10 months ago (2015-01-28 19:05:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886473003/40001
5 years, 10 months ago (2015-01-28 19:14:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886473003/60001
5 years, 10 months ago (2015-01-28 19:37:55 UTC) #18
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 19:44:52 UTC) #19
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/9d91eb313623dca16bc988bad2e8b01712e4c578

Powered by Google App Engine
This is Rietveld 408576698