Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Unified Diff: Source/core/frame/Window.idl

Issue 886463010: Make arguments to window.{move,resize}{To,By} non-optional (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebased Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/Window.idl
diff --git a/Source/core/frame/Window.idl b/Source/core/frame/Window.idl
index 156ac738ab1842be3d2dcd7b4708dce1fbf3c456..7930d5abcb5983f37dd71ab825c2085baff86b89 100644
--- a/Source/core/frame/Window.idl
+++ b/Source/core/frame/Window.idl
@@ -107,11 +107,10 @@
[SameObject, Replaceable] readonly attribute Screen screen;
// browsing context
- // FIXME: The x and y arguments should not be optional. crbug.com/453421
- void moveTo(optional long x, optional long y);
- void moveBy(optional long x, optional long y);
- void resizeTo(optional long x, optional long y);
- void resizeBy(optional long x, optional long y);
+ void moveTo(long x, long y);
+ void moveBy(long x, long y);
+ void resizeTo(long x, long y);
+ void resizeBy(long x, long y);
// viewport
[Replaceable] readonly attribute long innerWidth;
« Source/core/frame/LocalDOMWindow.cpp ('K') | « Source/core/frame/RemoteDOMWindow.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698