LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js - Issue 886463010: Make arguments to window.{move,resize}{To,By} non-optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

Issue 886463010: Make arguments to window.{move,resize}{To,By} non-optional (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebased Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt ('k') | LayoutTests/fast/forms/resources/picker-common.js » ('j') | Source/core/frame/LocalDOMWindow.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

diff --git a/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js b/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

index 9d5a8ad2eeae924e7217f0548e7ea250ef8e97da..64a447132b4f2db041154aab8bc524679c4df739 100644

--- a/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

+++ b/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

@@ -333,13 +333,13 @@ shouldBe("nonNumericPolicy('window.scrollTo(0, x)')", "'any type allowed (but no

shouldBe("nonNumericPolicy('window.scroll(x, 0)')", "'any type allowed'");

shouldBe("nonNumericPolicy('window.scroll(0, x)')", "'any type allowed (but not omitted)'");

shouldBe("nonNumericPolicy('window.moveBy(x, 0)')", "'any type allowed'");

-shouldBe("nonNumericPolicy('window.moveBy(0, x)')", "'any type allowed'");

+shouldBe("nonNumericPolicy('window.moveBy(0, x)')", "'any type allowed (but not omitted)'");

shouldBe("nonNumericPolicy('window.moveTo(x, 0)')", "'any type allowed'");

-shouldBe("nonNumericPolicy('window.moveTo(0, x)')", "'any type allowed'");

+shouldBe("nonNumericPolicy('window.moveTo(0, x)')", "'any type allowed (but not omitted)'");

shouldBe("nonNumericPolicy('window.resizeBy(x, 0)')", "'any type allowed'");

-shouldBe("nonNumericPolicy('window.resizeBy(0, x)')", "'any type allowed'");

+shouldBe("nonNumericPolicy('window.resizeBy(0, x)')", "'any type allowed (but not omitted)'");

shouldBe("nonNumericPolicy('window.resizeTo(x, 0)')", "'any type allowed'");

-shouldBe("nonNumericPolicy('window.resizeTo(0, x)')", "'any type allowed'");

+shouldBe("nonNumericPolicy('window.resizeTo(0, x)')", "'any type allowed (but not omitted)'");

// Not tested: openDatabase.

window.resizeTo(10000, 10000);