Make arguments to window.{move,resize}{To,By} non-optional

Source/core/frame/LocalDOMWindow.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 1210 matching lines @@
         scaledX = ScrollableArea::normalizeNonFiniteScroll(scrollToOptions.left()) * frame()->pageZoomFactor();
 
     if (scrollToOptions.hasTop())
         scaledY = ScrollableArea::normalizeNonFiniteScroll(scrollToOptions.top()) * frame()->pageZoomFactor();
 
     ScrollBehavior scrollBehavior = ScrollBehaviorAuto;
     ScrollableArea::scrollBehaviorFromString(scrollToOptions.behavior(), scrollBehavior);
     view->scrollableArea()->setScrollPosition(DoublePoint(scaledX, scaledY), ProgrammaticScroll, scrollBehavior);
 }
 
-void LocalDOMWindow::moveBy(int x, int y, bool hasX, bool hasY) const
+void LocalDOMWindow::moveBy(int x, int y) const
 {
-    if (!hasX || !hasY)
-        UseCounter::count(document(), UseCounter::WindowMoveResizeMissingArguments);

[philipj_slow, 2015/06/12 09:16:04]

Oh wait, can you remove the now-unused counters?

[philipj_slow, 2015/06/12 09:23:13]

Too late, but no need for a follow-up if you don't feel like it, I clean out
unused ones from time to time.

-
     if (!frame() || !frame()->isMainFrame())
         return;
 
     FrameHost* host = frame()->host();
     if (!host)
         return;
 
     IntRect windowRect = host->chromeClient().windowRect();
     windowRect.move(x, y);
     // Security check (the spec talks about UniversalBrowserWrite to disable this check...)
     host->chromeClient().setWindowRectWithAdjustment(windowRect);
 }
 
-void LocalDOMWindow::moveTo(int x, int y, bool hasX, bool hasY) const
+void LocalDOMWindow::moveTo(int x, int y) const
 {
-    if (!hasX || !hasY)
-        UseCounter::count(document(), UseCounter::WindowMoveResizeMissingArguments);
-
     if (!frame() || !frame()->isMainFrame())
         return;
 
     FrameHost* host = frame()->host();
     if (!host)
         return;
 
     IntRect windowRect = host->chromeClient().windowRect();
-    windowRect.setLocation(IntPoint(hasX ? x : windowRect.x(), hasY ? y : windowRect.y()));
+    windowRect.setLocation(IntPoint(x, y));
     // Security check (the spec talks about UniversalBrowserWrite to disable this check...)
     host->chromeClient().setWindowRectWithAdjustment(windowRect);
 }
 
-void LocalDOMWindow::resizeBy(int x, int y, bool hasX, bool hasY) const
+void LocalDOMWindow::resizeBy(int x, int y) const
 {
-    if (!hasX || !hasY)
-        UseCounter::count(document(), UseCounter::WindowMoveResizeMissingArguments);
-
     if (!frame() || !frame()->isMainFrame())
         return;
 
     FrameHost* host = frame()->host();
     if (!host)
         return;
 
     IntRect fr = host->chromeClient().windowRect();
     IntSize dest = fr.size() + IntSize(x, y);
     IntRect update(fr.location(), dest);
     host->chromeClient().setWindowRectWithAdjustment(update);
 }
 
-void LocalDOMWindow::resizeTo(int width, int height, bool hasWidth, bool hasHeight) const
+void LocalDOMWindow::resizeTo(int width, int height) const
 {
-    if (!hasWidth || !hasHeight)
-        UseCounter::count(document(), UseCounter::WindowMoveResizeMissingArguments);
-
     if (!frame() || !frame()->isMainFrame())
         return;
 
     FrameHost* host = frame()->host();
     if (!host)
         return;
 
     IntRect fr = host->chromeClient().windowRect();
-    IntSize dest = IntSize(hasWidth ? width : fr.width(), hasHeight ? height : fr.height());
+    IntSize dest = IntSize(width, height);
     IntRect update(fr.location(), dest);
     host->chromeClient().setWindowRectWithAdjustment(update);
 }
 
 int LocalDOMWindow::requestAnimationFrame(FrameRequestCallback* callback)
 {
     callback->m_useLegacyTimeBase = false;
     if (Document* d = document())
         return d->requestAnimationFrame(callback);
     return 0;
@@ skipping 224 matching lines @@
     DOMWindow::trace(visitor);
     DOMWindowLifecycleNotifier::trace(visitor);
 }
 
 LocalFrame* LocalDOMWindow::frame() const
 {
     return m_frameObserver->frame();
 }
 
 } // namespace blink