Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1226)

Issue 886463009: Update histograms.xml wrt new V8.Compile{Cacheable,Noncacheable}MicroSeconds histograms. (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update histograms.xml wrt new V8.Compile{Cacheable,Noncacheable}MicroSeconds histograms. R=asvitkine@chromium.org, vogelheim@chromium.org BUG=chromium:399580 Committed: https://crrev.com/bf0d63f917cdd5d537bc073135af5b91483c31ba Cr-Commit-Position: refs/heads/master@{#313716}

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comment (typo) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
This reflects this blink change: https://codereview.chromium.org/886713003/
5 years, 10 months ago (2015-01-29 08:42:10 UTC) #1
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/886463009/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/886463009/diff/1/tools/metrics/histograms/histograms.xml#newcode39821 tools/metrics/histograms/histograms.xml:39821: + Time spent compiling a script that maybe ...
5 years, 10 months ago (2015-01-29 14:38:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886463009/20001
5 years, 10 months ago (2015-01-29 15:07:34 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-29 16:06:37 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 16:07:40 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bf0d63f917cdd5d537bc073135af5b91483c31ba
Cr-Commit-Position: refs/heads/master@{#313716}

Powered by Google App Engine
This is Rietveld 408576698